All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
Date: Tue, 05 Jul 2005 22:11:41 +0000	[thread overview]
Message-ID: <200507060211.42028.adobriyan@gmail.com> (raw)
In-Reply-To: <cbecb30405070514134ebef46@mail.gmail.com>

On Wednesday 06 July 2005 01:13, Rodrigo Nascimento wrote:
> This patch changes the pci_find_device to pci_get_device.
> Please correct me, whether it's wrong. It is my first patch. :)

Thanks. It looks good except trivially fixable issues:
1. Long lines are wrapped.
2. Tabs are converted to spaces.

If you're using Gmail web-interface and copy-pasting patch, stop now. ;-) If
you're using email program, tune it a little.

> #

You can hack in your home directory. Much safer. You need root privileges
only when installing new kernel.

> diff -urpN /usr/src/linux/drivers/scsi/qla1280.c 
> /usr/src/linux-kj/drivers/scsi/qla1280.c
> --- /usr/src/linux/drivers/scsi/qla1280.c       2005-06-22
> 16:33:05.000000000 -0300
> +++ /usr/src/linux-kj/drivers/scsi/qla1280.c    2005-07-05
> 17:55:24.000000000 -0300

Patches are supposed to be "patch -p1" compliant. Paths should be
relative:

	--- linux/drivers/scsi/qla1280.c
	+++ linux-kj/drivers/scsi/qla1280.c

> @@ -1196,7 +1196,7 @@ qla1280_detect(Scsi_Host_Template *templ
>  #endif
> 
>         /* First Initialize QLA12160 on PCI Bus 1 Dev 2 */
> -       while ((pdev = pci_find_device(id->vendor, id->device, pdev))) {
> +       while ((pdev = pci_get_device(id->vendor, id->device, pdev))) {
>                 if (pdev->bus->number = 1 && PCI_SLOT(pdev->devfn) = 2) {
>                         if (!qla1280_probe_one(pdev, id))
>                                 num_hosts++;
> @@ -1206,7 +1206,7 @@ qla1280_detect(Scsi_Host_Template *templ
>         pdev = NULL;
>         /* Try and find each different type of adapter we support */
>         for (id = &qla1280_pci_tbl[0]; id->device; id++) {
> -               while ((pdev = pci_find_device(id->vendor, id->device, pdev))) {
> +               while ((pdev = pci_get_device(id->vendor, id->device, pdev))) {
>                         /*
>                          * skip QLA12160 already initialized on
>                          * PCI Bus 1 Dev 2 since we already initialized
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-07-05 22:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
2005-07-05 21:27 ` Greg KH
2005-07-05 22:11 ` Alexey Dobriyan [this message]
2005-07-05 22:45 ` Domen Puncer
2005-07-05 22:55 ` Greg KH
2005-07-06  8:39 ` Christoph Hellwig
2005-07-06  8:50 ` Domen Puncer
2005-07-06 14:35 ` Rodrigo Nascimento

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507060211.42028.adobriyan@gmail.com \
    --to=adobriyan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.