From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
Date: Wed, 06 Jul 2005 08:50:45 +0000 [thread overview]
Message-ID: <20050706085045.GB2232@homer.coderock.org> (raw)
In-Reply-To: <cbecb30405070514134ebef46@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On 05/07/05 15:55 -0700, Greg KH wrote:
> On Wed, Jul 06, 2005 at 12:45:10AM +0200, Domen Puncer wrote:
> > On 05/07/05 14:27 -0700, Greg KH wrote:
> > > On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> > > > This patch changes the pci_find_device to pci_get_device.
> > > > Please correct me, whether it's wrong. It is my first patch. :)
> > > >
> > > > Signed-off-by: Rodrigo Nascimento <underscore0x5f@gmail.com>
> > > >
> > > > # diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> > > > /usr/src/linux-kj/drivers/scsi/qla1280.c
> > > > --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> > > > 16:33:05.000000000 -0300
> > >
> > > Content looks good, but the patch is linwrapped and all of the tabs are
> > > converted to spaces, making it impossible to apply. And it's made at
> > > the wrong patch level :(
> >
> > Is pci_dev_put() not needed? Why not?
>
> Where would you place it?
Fail path of qla1280_probe_one(), qla1280_remove_one().
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-07-06 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
2005-07-05 21:27 ` Greg KH
2005-07-05 22:11 ` Alexey Dobriyan
2005-07-05 22:45 ` Domen Puncer
2005-07-05 22:55 ` Greg KH
2005-07-06 8:39 ` Christoph Hellwig
2005-07-06 8:50 ` Domen Puncer [this message]
2005-07-06 14:35 ` Rodrigo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050706085045.GB2232@homer.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.