[KJ] [PATCH 0/15] decrapify FlashPoint

[KJ] [PATCH 0/15] decrapify FlashPoint

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Don't pay attention to whatever whitespace left/added on the way. Lindent will
take care of it.

1) Mostly remove unused #defines.
2) Remove wrappers.

3-7) Switch to sane types.
8-13) Remove useless typedefs.

	Splitted for your reviewing pleasure.

14) Lindent the sucker.
15) return (*); => return *;

Compile tested with CONFIG_SCSI_OMIT_FLASHPOINT=y and =n.

If somebody will find useful the following script used in preparation of the
series, I'll be glad.
============================================================================
$ cat prepare
#!/bin/sh

PATCH="$1"
TEMP=${PATCH}_
echo "[PATCH] " >$TEMP
echo "" >>$TEMP
echo "Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>" >>$TEMP
echo "---" >>$TEMP
echo "" >>$TEMP
diffstat -p1 $PATCH >>$TEMP
echo "" >>$TEMP
cat $PATCH >>$TEMP
mv $TEMP $PATCH

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH 0/15] decrapify FlashPoint

[randy_dunlap]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

On Thu, 7 Jul 2005 03:20:14 +0400 Alexey Dobriyan wrote:

| Don't pay attention to whatever whitespace left/added on the way. Lindent will
| take care of it.
| 
| 1) Mostly remove unused #defines.
| 2) Remove wrappers.
| 
| 3-7) Switch to sane types.
| 8-13) Remove useless typedefs.
| 
| 	Splitted for your reviewing pleasure.

Looks sane to me.

| 14) Lindent the sucker.
| 15) return (*); => return *;
| 
| Compile tested with CONFIG_SCSI_OMIT_FLASHPOINT=y and =n.

Good job.  Some people forget to do things like that.  :)

| If somebody will find useful the following script used in preparation of the
| series, I'll be glad.

Thanks.

| ============================================================================
| $ cat prepare
| #!/bin/sh
| 
| PATCH="$1"
| TEMP=${PATCH}_
| echo "[PATCH] " >$TEMP
| echo "" >>$TEMP
| echo "Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>" >>$TEMP
| echo "---" >>$TEMP
| echo "" >>$TEMP
| diffstat -p1 $PATCH >>$TEMP
| echo "" >>$TEMP
| cat $PATCH >>$TEMP
| mv $TEMP $PATCH

Reference for others:  Linus wrote an email about the canonical
patch format.  It's here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=111289556807316&w=2

Alexey's prepare script is similar to what I use, genpatch,
which is contained in
  http://www.xenotime.net/linux/scripts/patching-scripts-003.tar.gz

---
~Randy

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors