From: Christoph Hellwig <hch@infradead.org>
To: Andrew Victor <andrew@sanpeople.com>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: [RFC] Atmel-supplied hardware headers for AT91RM9200 SoC processor
Date: Thu, 7 Jul 2005 14:06:08 +0100 [thread overview]
Message-ID: <20050707130607.GC28489@infradead.org> (raw)
In-Reply-To: <1120730318.16806.75.camel@fuzzie.sanpeople.com>
On Thu, Jul 07, 2005 at 11:58:39AM +0200, Andrew Victor wrote:
> While he seems generally happy with most of the code, he has doubts
> about merging the Atmel-supplied headers and suggested I post this to
> the linux-kernel list for a wider review.
>
> While I agree that their usage of structs/coding-style is not the
> cleanest/Linux way of doing things, re-using their headers is useful
> since:
> 1) they are supplied by the hardware manufacturer.
> 2) Atmel automatically generates them from their chip design database,
> so they should be correct.
> 3) they are used by most AT91RM9200 developers, not just those using
> Linux.
No reason to use the horror it is as-is. Beein hardware description they
won't change ever except for additions, so just clean the mess up into
somethign nice and submit them. You could have done so in the time you
spent arguing on linux-arm-kernel already.
next prev parent reply other threads:[~2005-07-07 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-07 9:58 [RFC] Atmel-supplied hardware headers for AT91RM9200 SoC processor Andrew Victor
2005-07-07 13:06 ` Christoph Hellwig [this message]
2005-07-11 13:35 ` Alan Cox
2005-07-11 13:57 ` Andrew Victor
2005-07-11 15:20 ` Alan Cox
2005-07-11 15:48 ` Christoph Hellwig
2005-07-07 14:41 ` David Woodhouse
2005-07-07 15:14 ` Andrew Victor
2005-07-07 15:26 ` David Woodhouse
2005-07-07 21:52 ` Alexey Dobriyan
2005-07-08 7:10 ` Andrew Victor
2005-07-08 14:50 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050707130607.GC28489@infradead.org \
--to=hch@infradead.org \
--cc=andrew@sanpeople.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.