All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Mansfield <patmans@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/scsi/qlogicfc.c: It's changes
Date: Thu, 07 Jul 2005 21:23:52 +0000	[thread overview]
Message-ID: <20050707212352.GA416@us.ibm.com> (raw)
In-Reply-To: <20050707010526.GA5406@garfield.casa.sp.br>

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Thu, Jul 07, 2005 at 01:56:51PM -0700, Greg KH wrote:
> On Thu, Jul 07, 2005 at 08:25:56PM +0100, Matthew Wilcox wrote:
> > On Thu, Jul 07, 2005 at 12:01:38PM -0700, Greg KH wrote:
> > > Please read the description of how pci_get_device() works.  In short it
> > > increments the reference count of the pci_dev that is returned.  Later
> > > on in this function, that pointer is saved off into a structure, which
> > > is fine.  Problem happens when that larger structure is freed when the
> > > device or driver is removed.  You need to decrement the usage count of
> > > that structure at that point in time.
> > > 
> > > Care to redo this?

qlogicfc is nearly dead, don't bother updating it, use the qla2xxx driver
instead. hch sent a patch to mark it broken, AFAICT patch was not included
anywhere, mabye because some people are still using it (well at least one
open-ended complaint on the thread).

Reference this thread (from February 2005):

http://marc.theaimsgroup.com/?l=linux-scsi&m=110805956618612&w=2

-- Patrick Mansfield

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-07-07 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-07  1:05 [KJ] [PATCH] drivers/scsi/qlogicfc.c: It's changes pci_find_device Rodrigo P. do Nascimento
2005-07-07 19:01 ` [KJ] [PATCH] drivers/scsi/qlogicfc.c: It's changes Greg KH
2005-07-07 19:25 ` Matthew Wilcox
2005-07-07 20:56 ` Greg KH
2005-07-07 21:23 ` Patrick Mansfield [this message]
2005-07-07 21:40 ` Rodrigo Nascimento

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050707212352.GA416@us.ibm.com \
    --to=patmans@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.