From: Alexey Dobriyan <adobriyan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [patch 2.6.13-rc1 03/23] Audit return code of create_proc_*
Date: Thu, 07 Jul 2005 22:24:23 +0000 [thread overview]
Message-ID: <200507080224.23895.adobriyan@gmail.com> (raw)
In-Reply-To: <20050707154524.160751000@rhum.iomeda.fr>
On Thursday 07 July 2005 19:44, Christophe Lucas wrote:
Subject: [KJ] [patch 2.6.13-rc1 03/23] Audit return code of create_proc_*
[patch 2.6.13-rc1 @num@/@total@] Audit return code of create_proc_*
Screwed script?
> --- 2.6.13-rc1.orig/drivers/net/tokenring/olympic.c
> +++ 2.6.13-rc1/drivers/net/tokenring/olympic.c
> @@ -265,13 +265,16 @@ static int __devinit olympic_probe(struc
> - printk("Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name);
> + printk(KERN_INFO "Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name);
> if (olympic_priv->olympic_network_monitor) { /* Must go after register_netdev as we need the device name */
> + struct proc_dir_entry* ent;
struct proc_dir_entry *ent;
> - create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,(void *)dev) ;
> - printk("Olympic: Network Monitor information: /proc/%s\n",proc_name);
> + ent = create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,(void *)dev) ;
> + if (!ent)
> + printk(KERN_WARNING "Olympic: Unable to create /proc entry.\n");
> + printk(KERN_INFO "Olympic: Network Monitor information: /proc/%s\n",proc_name);
If it wasn't created, what's the point?
> - printk("%s \n", version);
> - printk("%s. I/O at %hx, MMIO at %p, LAP at %p, using irq %d\n", olympic_priv->olympic_card_name, (unsigned int) dev->base_addr,olympic_priv->olympic_mmio, olympic_priv->olympic_lap, dev->irq);
> + printk(KERN_INFO "%s \n", version);
> + printk(KERN_INFO "%s. I/O at %hx, MMIO at %p, LAP at %p, using irq %d\n",
> + olympic_priv->olympic_card_name, (unsigned int) dev->base_addr,
> + olympic_priv->olympic_mmio, olympic_priv->olympic_lap, dev->irq);
Don't mix unrelated changes.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-07-07 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-07 15:44 [KJ] [patch 2.6.13-rc1 03/23] Audit return code of create_proc_* Christophe Lucas
2005-07-07 22:24 ` Alexey Dobriyan [this message]
2005-07-08 10:07 ` Christophe Lucas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507080224.23895.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.