From: Lars Marowsky-Bree <lmb@suse.de>
To: David Howells <dhowells@redhat.com>, torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Provide better printk() support for SMP machines [try #2]
Date: Fri, 8 Jul 2005 15:12:30 +0200 [thread overview]
Message-ID: <20050708131230.GH5674@marowsky-bree.de> (raw)
In-Reply-To: <31737.1120826172@warthog.cambridge.redhat.com>
On 2005-07-08T13:36:12, David Howells <dhowells@redhat.com> wrote:
> The attached patch prevents oopses interleaving with characters from other
> printks on other CPUs by only breaking the lock if the oops is happening on
> the machine holding the lock.
>
> It might be better if the oops generator got the lock and then called an inner
> vprintk routine that assumed the caller holds the lock, thus making oops
> reports "atomic".
>
> Signed-Off-By: David Howells <dhowells@redhat.com>
After some discussion on IRC (me asking dumb questions) and reviewing
the code I'm in infinite favour of this patch. It clearly is a step in a
mucho desireable direction.
Sincerely,
Lars Marowsky-Brée <lmb@suse.de>
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"
prev parent reply other threads:[~2005-07-08 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-05 20:10 [PATCH] Provide better printk() support for SMP machines David Howells
2005-07-05 21:29 ` Andrew Morton
2005-07-08 12:29 ` David Howells
2005-07-08 12:36 ` [PATCH] Provide better printk() support for SMP machines [try #2] David Howells
2005-07-08 13:12 ` Lars Marowsky-Bree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050708131230.GH5674@marowsky-bree.de \
--to=lmb@suse.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.