From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [patch 2.6.13-rc1 03/23][RESEND] Audit return code of
Date: Fri, 08 Jul 2005 14:59:49 +0000 [thread overview]
Message-ID: <20050708145948.GA2437@homer.coderock.org> (raw)
In-Reply-To: <20050708102212.GM4683@rhum.iomeda.fr>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
I thought only SCSI drivers are this scary. ;-)
On 08/07/05 12:22 +0200, Christophe Lucas wrote:
> Description:
> Audit return of create_proc_* functions and use of KERN_ in printk();
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
>
>
> Index: 2.6.13-rc1/drivers/net/tokenring/olympic.c
> -#if OLYMPIC_DEBUG
> +#if OLYMPIC_DEBUG
One space remains: ^ :-)
> #if OLYMPIC_DEBUG
> - printk("BCTL: %x\n",readl(olympic_mmio+BCTL));
> - printk("GPR: %x\n",readw(olympic_mmio+GPR));
> - printk("SISRMASK: %x\n",readl(olympic_mmio+SISR_MASK));
> + printk(KERN_DEBUG "BCTL: %x\n",readl(olympic_mmio+BCTL));
> + printk(KERN_DEBUG "GPR: %x\n",readw(olympic_mmio+GPR));
> + printk(KERN_DEBUG "SISRMASK: %x\n",readl(olympic_mmio+SISR_MASK));
> #endif
How about:
#if OLYMPIC_DEBUG
#define DEBUG
#endif
above includes, and then pr_debug(); or just drop OLYMPIC_DEBUG
and use DEBUG?
And return code audit should probably be in a separate patch?
Domen
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-07-08 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 10:22 [KJ] [patch 2.6.13-rc1 03/23][RESEND] Audit return code of Christophe Lucas
2005-07-08 14:59 ` Domen Puncer [this message]
2005-07-12 16:51 ` Christophe Lucas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050708145948.GA2437@homer.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.