All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Singer <elf@buici.com>
To: git@vger.kernel.org
Subject: Re: Bootstrapping into git, commit gripes at me
Date: Fri, 8 Jul 2005 18:11:19 -0700	[thread overview]
Message-ID: <20050709011119.GA10981@buici.com> (raw)
In-Reply-To: <7v4qb46dff.fsf@assigned-by-dhcp.cox.net>

>  $ git checkout -f v2.6.11 ;# fixed one
>  warning: v2.6.11 is not a commit -- not updating your HEAD
>  $ git commit ;# to have his own baseline at v2.6.11
>  $ git-apply --index --stat --summary --apply <../old-patch-file
>  $ : do the usual tests
>  $ git commit ;# create a commit based on the baseline v2.6.11

Interesting note.  I tried the git-apply command and found that it
complained and wouldn't succeed.

  elf@florence ~...embedded/linux-2.6 > git-apply --index --stat --summary --apply < ../ms16/ide.patch 
  error: patch failed: drivers/ide/ide-io.c:129
  error: drivers/ide/ide-io.c: patch does not apply

Yet, patch does apply.

  elf@florence ~...embedded/linux-2.6 > patch -p1 < ../ms16/ide.patch
  patching file drivers/ide/arm/ide_arm.c
  patching file drivers/ide/arm/ide-lpd7952x.c
  patching file drivers/ide/arm/ide-lpd7a40x.c
  patching file drivers/ide/arm/Makefile
  patching file drivers/ide/ide-disk.c
  Hunk #1 succeeded at 282 (offset 41 lines).
  Hunk #2 succeeded at 294 (offset 41 lines).
  patching file drivers/ide/ide-io.c
  Hunk #1 succeeded at 96 with fuzz 2 (offset -33 lines).
  Hunk #2 succeeded at 1227 (offset 189 lines).
  Hunk #3 succeeded at 1388 (offset 189 lines).
  Hunk #4 succeeded at 1689 (offset 187 lines).
  patching file drivers/ide/ide-iops.c
  patching file drivers/ide/ide-probe.c
  Hunk #1 succeeded at 422 (offset 51 lines).
  Hunk #2 succeeded at 784 (offset 59 lines).
  Hunk #3 succeeded at 847 (offset 59 lines).
  Hunk #4 succeeded at 1112 (offset 64 lines).
  Hunk #5 succeeded at 1172 (offset 64 lines).
  patching file drivers/ide/Kconfig
  Hunk #1 succeeded at 272 (offset -1 lines).
  Hunk #2 succeeded at 781 (offset 5 lines).
  patching file drivers/ide/legacy/ht6560b.c
  patching file drivers/ide/legacy/qd65xx.c
  patching file drivers/ide/pci/ns87415.c
  patching file drivers/ide/pci/sl82c105.c
  patching file drivers/ide/pci/trm290.c
  patching file drivers/ide/ppc/pmac.c
  Hunk #1 succeeded at 572 (offset 61 lines).
  Hunk #2 succeeded at 596 (offset 61 lines).
  patching file include/linux/ide.h
  Hunk #1 succeeded at 961 (offset 1 line).
  Hunk #2 succeeded at 1497 (offset -14 lines).

It should be obvious that a patch that doesn't apply cleanly,
i.e. without rejects, is still useful to apply so that I can fix the
places where it fails.

  o Why does patch work and git-apply fail?
  o Is there a way to force git to apply and safe the rejects?

  parent reply	other threads:[~2005-07-09  1:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-08 23:07 Bootstrapping into git, commit gripes at me Marc Singer
     [not found] ` <7v4qb46dff.fsf@assigned-by-dhcp.cox.net>
2005-07-09  1:11   ` Marc Singer [this message]
2005-07-09 21:04     ` Matthias Urlichs
2005-07-10 15:06       ` Petr Baudis
     [not found]   ` <20050709003636.GA26526@buici.com>
     [not found]     ` <7v1x684wgr.fsf@assigned-by-dhcp.cox.net>
2005-07-09  1:16       ` Marc Singer
2005-07-09  1:31         ` Junio C Hamano
2005-07-09  1:43 ` Linus Torvalds
2005-07-11 22:20   ` Marc Singer
2005-07-11 23:03     ` Junio C Hamano
2005-07-11 23:15       ` Junio C Hamano
2005-07-12  0:57       ` Linus Torvalds
2005-07-12  1:43         ` Linus Torvalds
2005-07-12  2:10           ` Marc Singer
2005-07-12  3:09             ` Linus Torvalds
2005-07-12  3:49               ` Linus Torvalds
2005-07-12  4:34                 ` Linus Torvalds
2005-07-12  4:43                   ` Marc Singer
2005-07-12  4:59                     ` Linus Torvalds
2005-07-12  5:12                       ` Marc Singer
2005-07-12  7:48                   ` Petr Baudis
2005-07-12  9:07                     ` Junio C Hamano
2005-07-12 16:29                       ` Matthias Urlichs
2005-07-24  8:57                       ` Petr Baudis
2005-07-24 16:24                         ` Junio C Hamano
2005-07-12 16:48                     ` Linus Torvalds
2005-08-12  1:26                       ` Petr Baudis
2005-07-12  2:21           ` Junio C Hamano
2005-07-12  3:18             ` Linus Torvalds
2005-07-12  3:41               ` Junio C Hamano
2005-07-12  3:52                 ` Linus Torvalds
2005-07-12  3:53                 ` Marc Singer
2005-07-12 17:04             ` Daniel Barkalow
2005-07-11 23:45     ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2005-07-09  0:40 Marc Singer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050709011119.GA10981@buici.com \
    --to=elf@buici.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.