From: Adrian Bunk <bunk@stusta.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [2.6 patch] SCSI_SATA has to be a tristate
Date: Sat, 9 Jul 2005 03:24:00 +0200 [thread overview]
Message-ID: <20050709012359.GO3671@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0507090134040.3743@scrub.home>
On Sat, Jul 09, 2005 at 01:36:08AM +0200, Roman Zippel wrote:
> Hi,
>
> On Fri, 8 Jul 2005, Adrian Bunk wrote:
>
> > --- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
> > +++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
> > @@ -447,7 +447,7 @@
> > source "drivers/scsi/megaraid/Kconfig.megaraid"
> >
> > config SCSI_SATA
> > - bool "Serial ATA (SATA) support"
> > + tristate "Serial ATA (SATA) support"
> > depends on SCSI
> > help
> > This driver family supports Serial ATA host controllers
>
> Did you verify that this works?
> Overwise "depends on SCSI=y" might also be correct.
Yes, I did.
The problem is that all the SATA drivers depend on SCSI_SATA.
With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
-> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
-> SCSI_ATA_ADMA and libata are built statically but
scsi/built-in.o is not linked into the kernel,
SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
libata)
Making SCSI_SATA a tristate solves all these problems.
"depends on SCSI=y" would also solve these problems, but it would leave
people with modular SCSI without SATA support...
> bye, Roman
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-07-09 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 21:48 [2.6 patch] SCSI_SATA has to be a tristate Adrian Bunk
2005-07-08 23:36 ` Roman Zippel
2005-07-09 0:05 ` Jeff Garzik
2005-07-09 1:24 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-15 21:35 Adrian Bunk
2005-07-02 16:50 2.6.13-rc1-mm1 Zoltan Boszormenyi
2005-07-02 21:43 ` [2.6 patch] SCSI_SATA has to be a tristate Adrian Bunk
2005-07-03 14:01 ` Zoltan Boszormenyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050709012359.GO3671@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.