All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	tglx@linutronix.de
Subject: Re: [MTD] XIP cleanup
Date: Tue, 12 Jul 2005 22:01:14 +0200	[thread overview]
Message-ID: <20050712200114.GA6165@suse.de> (raw)
In-Reply-To: <200507111906.j6BJ6fDu007639@hera.kernel.org>

 On Mon, Jul 11, Linux Kernel Mailing List wrote:

> tree d571cdae6507be90d4ee67d4937b765e2b332d77
> parent b9c86d595d2a11009c58c84a9a8792aeb4a8f278
> author Thomas Gleixner <tglx@tglx.tec.linutronix.de> Thu, 07 Jul 2005 16:50:16 +0200
> committer Thomas Gleixner <tglx@mtd.linutronix.de> Thu, 07 Jul 2005 16:50:16 +0200
> 
> [MTD] XIP cleanup
> 
> Move the architecture dependend code into include/asm/mtd-xip.h
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
>  drivers/mtd/chips/cfi_cmdset_0001.c   |    2 -
>  drivers/mtd/chips/cfi_cmdset_0002.c   |    2 -
>  include/asm-arm/arch-pxa/mtd-xip.h    |   37 ++++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-sa1100/mtd-xip.h |   26 +++++++++++++++++++++++
>  include/asm-arm/mtd-xip.h             |   26 +++++++++++++++++++++++
>  include/linux/mtd/xip.h               |   31 +++++++++++-----------------
>  6 files changed, 104 insertions(+), 20 deletions(-)

> diff --git a/include/linux/mtd/xip.h b/include/linux/mtd/xip.h
> --- a/include/linux/mtd/xip.h
> +++ b/include/linux/mtd/xip.h
> @@ -58,22 +58,16 @@
>   * 		returned value is <= the real elapsed time.
>   * 	note 2: this should be able to cope with a few seconds without
>   * 		overflowing.
> + *
> + * xip_iprefetch()
> + *  
> + *      Macro to fill instruction prefetch
> + *	e.g. a series of nops:  asm volatile (".rep 8; nop; .endr"); 
>   */
>  
> -#if defined(CONFIG_ARCH_SA1100) || defined(CONFIG_ARCH_PXA)
> +#include <asm/mtd-xip.h>

How is that supposed to work?
Should each arch provide their own header file?
Should certion .config options depend on ARM or $FOO?
I assume most of the mtd drivers are not intended for the average
Walmart PC.



       reply	other threads:[~2005-07-12 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200507111906.j6BJ6fDu007639@hera.kernel.org>
2005-07-12 20:01 ` Olaf Hering [this message]
2005-07-12 20:19   ` [MTD] XIP cleanup Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050712200114.GA6165@suse.de \
    --to=olh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.