Re: [MTD] XIP cleanup

Re: [MTD] XIP cleanup

[Olaf Hering]

 On Mon, Jul 11, Linux Kernel Mailing List wrote:

> tree d571cdae6507be90d4ee67d4937b765e2b332d77
> parent b9c86d595d2a11009c58c84a9a8792aeb4a8f278
> author Thomas Gleixner <tglx@tglx.tec.linutronix.de> Thu, 07 Jul 2005 16:50:16 +0200
> committer Thomas Gleixner <tglx@mtd.linutronix.de> Thu, 07 Jul 2005 16:50:16 +0200
> 
> [MTD] XIP cleanup
> 
> Move the architecture dependend code into include/asm/mtd-xip.h
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
>  drivers/mtd/chips/cfi_cmdset_0001.c   |    2 -
>  drivers/mtd/chips/cfi_cmdset_0002.c   |    2 -
>  include/asm-arm/arch-pxa/mtd-xip.h    |   37 ++++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-sa1100/mtd-xip.h |   26 +++++++++++++++++++++++
>  include/asm-arm/mtd-xip.h             |   26 +++++++++++++++++++++++
>  include/linux/mtd/xip.h               |   31 +++++++++++-----------------
>  6 files changed, 104 insertions(+), 20 deletions(-)

> diff --git a/include/linux/mtd/xip.h b/include/linux/mtd/xip.h
> --- a/include/linux/mtd/xip.h
> +++ b/include/linux/mtd/xip.h
> @@ -58,22 +58,16 @@
>   * 		returned value is <= the real elapsed time.
>   * 	note 2: this should be able to cope with a few seconds without
>   * 		overflowing.
> + *
> + * xip_iprefetch()
> + *  
> + *      Macro to fill instruction prefetch
> + *	e.g. a series of nops:  asm volatile (".rep 8; nop; .endr"); 
>   */
>  
> -#if defined(CONFIG_ARCH_SA1100) || defined(CONFIG_ARCH_PXA)
> +#include <asm/mtd-xip.h>

How is that supposed to work?
Should each arch provide their own header file?
Should certion .config options depend on ARM or $FOO?
I assume most of the mtd drivers are not intended for the average
Walmart PC.

Re: [MTD] XIP cleanup

[Thomas Gleixner]

On Tue, 2005-07-12 at 22:01 +0200, Olaf Hering wrote:

> How is that supposed to work?
> Should each arch provide their own header file?
> Should certion .config options depend on ARM or $FOO?
> I assume most of the mtd drivers are not intended for the average
> Walmart PC.

The dependency on ARM slipped through when I updated the git tree from
MTD-CVS. 

It's fixed in the MTD git tree.

tglx