All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Kirch <okir@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH] Fill in rqstp->rq_daddr in svc_tcp_recvfrom
Date: Wed, 13 Jul 2005 07:17:50 +0200	[thread overview]
Message-ID: <20050713051750.GA23673@suse.de> (raw)
In-Reply-To: <20050712163146.GC27938@fieldses.org>

Hi Bruce,

> Could you explain how this patch makes a difference?  I can only see the
> value of rq_daddr used in one place, in svc_sendto:

It doesn't make a difference for the existing RPC users, but the customer
had some kernel RPC code of their own (I think some HA capable nfsd)
that needed this information for migration/failover.

It's not strictly necessary, but it doesn't hurt either - and it makes
sense in the way that UDP and TCP now fill in the same set of information.

Olaf
-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
okir@suse.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax


-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP, 
AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2005-07-13  5:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-12  9:04 [PATCH] Fill in rqstp->rq_daddr in svc_tcp_recvfrom Olaf Kirch
2005-07-12 16:31 ` J. Bruce Fields
2005-07-13  5:17   ` Olaf Kirch [this message]
2005-07-13 14:36     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050713051750.GA23673@suse.de \
    --to=okir@suse.de \
    --cc=bfields@fieldses.org \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.