From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Sam Song <samlinuxkernel@yahoo.com>
Cc: mgreer@mvista.com, david-b@pacbell.net, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.13-git] 8250 tweaks
Date: Thu, 14 Jul 2005 11:42:20 +0100 [thread overview]
Message-ID: <20050714114220.C31383@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050714071202.88368.qmail@web32007.mail.mud.yahoo.com>; from samlinuxkernel@yahoo.com on Thu, Jul 14, 2005 at 12:12:02AM -0700
On Thu, Jul 14, 2005 at 12:12:02AM -0700, Sam Song wrote:
> It turned out the conflict of uart init definition
> like MPC10X_UART0_IRQ in ../syslib/mpc10x_common.c
> and SERIAL_PORT_DFNS in ../platform/sandpoint.h. By
> now, only MPC10X_UART0_IRQ stuff is needed.
> SERIAL_PORT_DFNS should be omitted.
Oh dear, it seems that I missed a load of fixups then. I only
scanned include/asm-* for SERIAL_PORT_DFNS - and I stupidly
thought that PPC this "platform" directory would be in include/asm-ppc.
> Seems it's time for me to stand with Russell:-)
Well, in this case, the "whinging" resulted in finding a _real_ bug
and locating why your ports weren't being found. So I guess it's
good for something.
Can you mail me a diff of the changes you made to
arch/ppc/platforms/sandpoint.h please? If that file is being used
it seems that you actually have 4 ports defined in total. However,
I'm a little confused because the sandpoint.h defines don't seem to
match your original dmesg output.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-07-14 10:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 2:22 [patch 2.6.13-git] 8250 tweaks David Brownell
2005-07-12 7:19 ` Russell King
2005-07-12 9:14 ` Russell King
2005-07-12 10:25 ` david-b
2005-07-12 11:08 ` Russell King
2005-07-12 11:32 ` david-b
2005-07-12 12:01 ` Russell King
2005-07-12 13:30 ` david-b
2005-07-12 14:00 ` Russell King
2005-07-13 4:55 ` Sam Song
2005-07-13 6:12 ` Russell King
2005-07-13 10:51 ` Sam Song
2005-07-13 12:48 ` Russell King
2005-07-14 7:12 ` Sam Song
2005-07-14 10:42 ` Russell King [this message]
2005-07-15 5:11 ` Sam Song
2005-07-16 8:43 ` Russell King
2005-07-16 10:12 ` Sam Song
2005-07-16 10:15 ` Russell King
2005-07-16 12:31 ` Sam Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050714114220.C31383@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=samlinuxkernel@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.