All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@systemhalted.org>
To: John David Anglin <dave@hiauly1.hia.nrc.ca>
Cc: tausq@debian.org, parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Re: Non-inline math, and inline math broken, GCC to blame? (1 hppa tls toolchain regression).
Date: Fri, 15 Jul 2005 21:14:33 -0400	[thread overview]
Message-ID: <20050716011432.GD5314@systemhalted.org> (raw)
In-Reply-To: <20050716005715.GC5314@systemhalted.org>

On Fri, Jul 15, 2005 at 08:57:15PM -0400, Carlos O'Donell wrote:
> I don't quite understand how something like "fpclassify" can *ever* fail
> under any implementation.
> 
> Could you review these files:
> http://cvs.parisc-linux.org/glibc/sysdeps/hppa/fpu/
> 
> With an eye to correct asm statement? If these don't work then it all
> goes down the tubes. I'm sure gcc is probably doing the right thing and
> that asm is doing the wrong thing.

I think gcc is to blame, or the constraints in the assembly?

--- GCC 4.0 ---

0x40349890 <feclearexcept+0>:   ldo 40(sp),sp
0x40349894 <feclearexcept+4>:   ldo -38(sp),ret0
0x40349898 <feclearexcept+8>:   stw r19,-20(,sp)
0x4034989c <feclearexcept+12>:  fstd fr0,0(,ret0)
0x403498a0 <feclearexcept+16>:  fldd 0(,ret0),fr0
0x403498a4 <feclearexcept+20>:  ldi 0,ret0
0x403498a8 <feclearexcept+24>:  bv r0(rp)
0x403498ac <feclearexcept+28>:  ldo -40(sp),sp

Notice that it thinks the argument is on the stack? Are the assembly
constraints confusing gcc?

The above is competely bogus.

--- GCC 3.3.5 ---

00000000 <feclearexcept>:
   0:   37 de 00 80     ldo 40(sp),sp
   4:   d7 5a 0b 7b     depw,z r26,4,5,r26
   8:   6b d3 3f c1     stw r19,-20(,sp)
   c:   37 d4 3f 91     ldo -38(sp),r20
  10:   2e 80 12 00     fstd fr0,0(,r20)
  14:   4b d5 3f 91     ldw -38(,sp),r21
  18:   0b 55 00 1a     andcm r21,r26,r26
  1c:   6b da 3f 91     stw r26,-38(,sp)
  20:   2e 80 10 00     fldd 0(,r20),fr0
  24:   34 1c 00 00     ldi 0,ret0
  28:   e8 40 c0 00     bv r0(rp)
  2c:   37 de 3f 81     ldo -40(sp),sp

This one properly loads the value from r26.
This one works.

c.

_______________________________________________
parisc-linux mailing list
parisc-linux@lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

  reply	other threads:[~2005-07-16  1:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-15 14:26 [parisc-linux] TLS toolchain update (6 regressions left) Carlos O'Donell
2005-07-15 23:44 ` [parisc-linux] Non-inline math, and inline math broken, GCC to blame? (1 hppa tls toolchain regression) Carlos O'Donell
2005-07-16  0:08   ` [parisc-linux] " John David Anglin
2005-07-16  0:57     ` Carlos O'Donell
2005-07-16  1:14       ` Carlos O'Donell [this message]
2005-07-16  1:54         ` John David Anglin
2005-07-16 18:38           ` Carlos O'Donell
2005-07-16 19:15             ` John David Anglin
2005-07-16 19:16               ` Carlos O'Donell
2005-07-16 19:48                 ` John David Anglin
2005-07-16 20:13                   ` Carlos O'Donell
2005-07-16 20:29                     ` John David Anglin
2005-07-16 21:18                       ` Carlos O'Donell
2005-07-16 22:55                         ` John David Anglin
2005-07-17 16:21 ` [parisc-linux] TLS toolchain update (6 regressions left) Carlos O'Donell
     [not found] <no.id>
2005-07-16  2:55 ` [parisc-linux] Re: Non-inline math, and inline math broken, GCC to blame? (1 hppa tls toolchain regression) John David Anglin
2005-07-16 16:16   ` Carlos O'Donell
2005-07-16 17:37     ` John David Anglin
2005-07-16 17:54       ` John David Anglin
2005-07-16 19:41         ` Carlos O'Donell
2005-07-16 19:56           ` John David Anglin
2005-07-16 19:15       ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050716011432.GD5314@systemhalted.org \
    --to=carlos@systemhalted.org \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=parisc-linux@lists.parisc-linux.org \
    --cc=tausq@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.