All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] EXIT_CONNECTOR and FORK_CONNECTOR must depend on NET
Date: Sun, 17 Jul 2005 22:48:20 +0200	[thread overview]
Message-ID: <20050717204820.GD3753@stusta.de> (raw)

If you select some variable, you have to ensure that the dependencies of 
the select'ed variable are fulfilled.

This patch fixes the following link error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `alloc_skb'
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `netlink_broadcast'
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `__kfree_skb'
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `skb_over_panic'
drivers/built-in.o: In function `cn_rx_skb':
connector.c:(.text+0x20d809): undefined reference to `__kfree_skb'
drivers/built-in.o: In function `cn_input':
connector.c:(.text+0x20d91e): undefined reference to `skb_dequeue'
drivers/built-in.o: In function `cn_init':
connector.c:(.text+0x20dedc): undefined reference to 
`netlink_kernel_create'
connector.c:(.text+0x20df67): undefined reference to `sock_release'
drivers/built-in.o: In function `kfree_skb':
connector.c:(.text+0x20d756): undefined reference to `__kfree_skb'
drivers/built-in.o: In function `cn_rx_skb':
connector.c:(.text+0x20d7c8): undefined reference to `__kfree_skb'
connector.c:(.text+0x20d87e): undefined reference to `__kfree_skb'
drivers/built-in.o: In function `cn_fini':
connector.c:(.text+0x20dfae): undefined reference to `sock_release'
drivers/built-in.o: In function `w1_alloc_dev':
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc3-mm1-full/drivers/connector/Kconfig.old	2005-07-17 22:35:33.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/connector/Kconfig	2005-07-17 22:36:12.000000000 +0200
@@ -1,35 +1,37 @@
 menu "Connector - unified userspace <-> kernelspace linker"
 
 config CONNECTOR
 	tristate "Connector - unified userspace <-> kernelspace linker"
 	depends on NET
 	---help---
 	  This is unified userspace <-> kernelspace connector working on top
 	  of the netlink socket protocol.
 
 	  Connector support can also be built as a module.  If so, the module
 	  will be called cn.ko.
 
 config EXIT_CONNECTOR
 	bool "Enable exit connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/exit.c:do_exit() function. When a exit
 	  occurs, netlink is used to transfer information about the process and
 	  its parent. This information can be used by a user space application.
 	  The exit connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 config FORK_CONNECTOR
 	bool "Enable fork connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/fork.c:do_fork() function. When a fork
 	  occurs, netlink is used to transfer information about the parent and
 	  its child. This information can be used by a user space application.
 	  The fork connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 endmenu


             reply	other threads:[~2005-07-17 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-17 20:48 Adrian Bunk [this message]
2005-07-18  7:33 ` [-mm patch] EXIT_CONNECTOR and FORK_CONNECTOR must depend on NET Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050717204820.GD3753@stusta.de \
    --to=bunk@stusta.de \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.