Re: [PATCH 3/*] ctnetlink major update

[Harald Welte <laforge@netfilter.org>]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

On Tue, Jul 12, 2005 at 10:36:48PM +0200, Pablo Neira wrote:
> Sorry, this patch has been gzip'ed since I wasn't sure if it excedees the 
> maximun size allowed that can be sent to the mailling list (bigger than 30K).
 
it's 40k, and you can send larger emails, they will be administratively
approved by Travis, our listmaster.  Please only send text attachments.

> I didn't generate the incremental diff against the previous version since it 
> doesn't make too many sense because this update introduces too many changes.

it _always_ makes sense.  Everybody reviewing your patch will otherwise
have to create such a diff before he can reasonably review.

> ip_conntrack_netlink doesn't use ip_conntrack structures anymore, instead we 
> use nested ctnetlink atributes. This way protect us against furture changes 
> that could break backward compatibility. And now it's fairly easy
> porting this to nfnetlink.

ACK.

> getting, creation, deletion of expectation isn't implemented yet. I kept it 
> back until my come back, I didn't have enough time to finish it. Anyway, 
> porting the old expectation handling functions to support ctnetlink
> attributes must be an easy job. If someone is interested, I kept those
> old functions here:

I'll be adding them to your recent changes.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]