All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/net/ne2k-pci.c : Use of the time_after()
Date: Mon, 18 Jul 2005 16:18:23 +0000	[thread overview]
Message-ID: <20050718161823.GE2457@homer.coderock.org> (raw)
In-Reply-To: <425F030B.5000008@feitoza.com.br>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On 16/07/05 04:17 -0300, Marcelo Feitoza Parisi wrote:

> Use of the time_after() macro, defined at linux/jiffies.h, which deal
> with wrapping correctly and are nicer to read.
> 
> Signed-off-by: Marcelo Feitoza Parisi <marcelo@feitoza.com.br>
> 
> --- linux/drivers/net/ne2k-pci.c	2005-07-13 17:53:29.000000000 -0300
> +++ linux-kj/drivers/net/ne2k-pci.c	2005-07-15 22:21:44.302017824 -0300
> @@ -280,7 +280,7 @@
>  		*/
>  		while ((inb(ioaddr + EN0_ISR) & ENISR_RESET) == 0)
>  			/* Limit wait: '2' avoids jiffy roll-over. */

We can get rid of the comment.

> -			if (jiffies - reset_start_time > 2) {

> +			if (time_after(jiffies, reset_start_time + 2)) {

And use just "> 1", as it still guarantees 1 jiffie.

> +		if (time_after(jiffies, reset_start_time + 2)) {

> +		if (time_after(jiffies, dma_start + 2)) {	/* Avoid clock roll-over. */


Also, HZ and/or whitespace issues with:
drivers/net/eexpress.c
drivers/net/eth16i.c
drivers/atm/iphase.c

OK, whitespace I can fix quickly, but for HZ figure out what is
intended, and resend with that in description. Thanks.

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-07-18 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14 23:55 [KJ] [PATCH] drivers/net/ne2k-pci.c : Use of time_after() macro Marcelo Feitoza Parisi
2005-04-15  1:33 ` Mark Hollomon
2005-07-16  7:17 ` [KJ] [PATCH] drivers/net/ne2k-pci.c : Use of the " Marcelo Feitoza Parisi
2005-07-18 16:18 ` Domen Puncer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050718161823.GE2457@homer.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.