From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Duxun-00042P-Lz for mharc-grub-devel@gnu.org; Tue, 19 Jul 2005 15:38:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Duxuh-000411-Jl for grub-devel@gnu.org; Tue, 19 Jul 2005 15:38:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Duxue-0003zt-9Q for grub-devel@gnu.org; Tue, 19 Jul 2005 15:37:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Duxuc-0003yl-JC for grub-devel@gnu.org; Tue, 19 Jul 2005 15:37:55 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Duy0G-0002Ea-0H for grub-devel@gnu.org; Tue, 19 Jul 2005 15:43:44 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 94C93FED3E00 for ; Tue, 19 Jul 2005 21:34:10 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 19 Jul 05 19:34:10 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Tue, 19 Jul 2005 21:33:45 +0200 User-Agent: KMail/1.7.2 References: <20050716225439.96F7A6EEF6@ws1-5.us4.outblaze.com> <11095bcfc8289c38cb4bd5cc613d1347@penguinppc.org> In-Reply-To: <11095bcfc8289c38cb4bd5cc613d1347@penguinppc.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200507192133.45201.okuji@enbug.org> Subject: Re: [PATCH] new ELF64 patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2005 19:38:01 -0000 On Monday 18 July 2005 17:18, Hollis Blanchard wrote: > I don't like this. I would prefer having grub_rescue_cmd_multiboot() > call two functions: grub_load_elf32() and grub_load_elf64(): > > grub_load_elf32(Elf32_Ehdr *header) > { > if (header->e_ident[EI_CLASS] != ELFCLASS32) > return error; > > /* load segments */ > ... > } I agree. This is more readable. Okuji