From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DvLam-0005i1-Ef for mharc-grub-devel@gnu.org; Wed, 20 Jul 2005 16:55:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DvLab-0005dM-Tx for grub-devel@gnu.org; Wed, 20 Jul 2005 16:54:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DvLaR-0005WC-Fi for grub-devel@gnu.org; Wed, 20 Jul 2005 16:54:42 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DvLaQ-0005VS-Mp for grub-devel@gnu.org; Wed, 20 Jul 2005 16:54:38 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DvLgQ-0002W4-BT for grub-devel@gnu.org; Wed, 20 Jul 2005 17:00:50 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id EEE6AF968E37 for ; Wed, 20 Jul 2005 22:50:59 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 20 Jul 05 20:50:59 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Wed, 20 Jul 2005 22:50:32 +0200 User-Agent: KMail/1.7.2 References: <20050719230122.F19A64BEAD@ws1-1.us4.outblaze.com> In-Reply-To: <20050719230122.F19A64BEAD@ws1-1.us4.outblaze.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200507202250.33112.okuji@enbug.org> Subject: Re: [PATCH] ELF64 and changelog and 4Gb X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2005 20:54:57 -0000 On Wednesday 20 July 2005 01:01, Ruslan Nikolaev wrote: > > I agree. This is more readable. > > I can change it of course... But it is not so bad: Well, I think the problem is that there is no meaning to use a union here, and it makes the function too long. > Ok... But first I have a question about grub2. Does it really provide > "mmap" information for OS as multiboot defined or memory size only? As this is written in the comment, this is not implemented yet. > As for 4Gb limit: > > 1. Memory size variable is a 32-bit. It measures in bytes => max 4Gb. > When it passes to OS it converts to KB measuring but it's still truncated > to 4Gb. But this itself is not a bug really. Because mem_upper is the size of a contiguous region starting from 1MB, and every BIOS has one or more memory holes before 4GB. Well, there is a 4GB limit. We must implement memory map passing. > 2005-07-17 Ruslan Nikolaev > > * multiboot.c (grub_rescue_cmd_multiboot): using ELF64 loading code if > ELF CLASS is a 64-bit and CPU CLASS is X86_64 Please look at the examples carefully. The rule is the same as C comments: Also, please write complete sentences and capitalize the first word. If a lower-case identifier comes at the beginning of a sentence, don't capitalize it! Changing the spelling makes it a different identifier. If you don't like starting a sentence with a lower case letter, write the sentence differently (e.g., “The identifier lower-case is ...”). Okuji