From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261226AbVG0W6A (ORCPT ); Wed, 27 Jul 2005 18:58:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261224AbVG0Wz5 (ORCPT ); Wed, 27 Jul 2005 18:55:57 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:51640 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261179AbVG0Wxp (ORCPT ); Wed, 27 Jul 2005 18:53:45 -0400 Date: Thu, 28 Jul 2005 00:53:34 +0200 From: Pavel Machek To: Linus Torvalds Cc: "Eric W. Biederman" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/23] reboot-fixes Message-ID: <20050727225334.GC6529@elf.ucw.cz> References: <20050727025923.7baa38c9.akpm@osdl.org> <20050727104123.7938477a.akpm@osdl.org> <20050727224711.GA6671@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > Yes, I think we should do device_suspend(PMSG_FREEZE) in reboot path. > > Considering how many device drivers that are likely broken, I disagree. > Especially since Andrew seems to have trivially found a machine where it > doesn't work. I'm not sure if we want to do that for 2.6.13, but long term, we should just tell drivers to FREEZE instead of inventing reboot notifier lists and similar uglynesses... Pavel -- teflon -- maybe it is a trademark, but it should not be.