All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	Richard Henderson <rth@twiddle.net>,
	rgooch@atnf.csiro.au
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] fix MTRR compilation with SMP=n
Date: Thu, 28 Jul 2005 12:44:39 +0200	[thread overview]
Message-ID: <20050728104439.GE3572@stusta.de> (raw)
In-Reply-To: <20050728025840.0596b9cb.akpm@osdl.org>

On Thu, Jul 28, 2005 at 02:58:40AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.13-rc3-mm2:
>...
> +alpha-fix-statement-with-no-effect-warnings.patch
> 
>  Alpha warning fixes
>...

This patch broke the compilation on i386 with CONFIG_SMP=n and 
CONFIG_MTRR=y:

<--  snip  -->

...
  CC      arch/i386/kernel/cpu/mtrr/main.o
arch/i386/kernel/cpu/mtrr/main.c: In function 'set_mtrr':
arch/i386/kernel/cpu/mtrr/main.c:225: error: 'ipi_handler' undeclared (first use in this function)
arch/i386/kernel/cpu/mtrr/main.c:225: error: (Each undeclared identifier is reported only once
arch/i386/kernel/cpu/mtrr/main.c:225: error: for each function it appears in.)
make[3]: *** [arch/i386/kernel/cpu/mtrr/main.o] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc3-mm3/arch/i386/kernel/cpu/mtrr/main.c.old	2005-07-28 12:36:09.000000000 +0200
+++ linux-2.6.13-rc3-mm3/arch/i386/kernel/cpu/mtrr/main.c	2005-07-28 12:39:35.000000000 +0200
@@ -221,9 +221,11 @@
 	atomic_set(&data.count, num_booting_cpus() - 1);
 	atomic_set(&data.gate,0);
 
+#ifdef CONFIG_SMP
 	/*  Start the ball rolling on other CPUs  */
 	if (smp_call_function(ipi_handler, &data, 1, 0) != 0)
 		panic("mtrr: timed out waiting for other CPUs\n");
+#endif  /*  CONFIG_SMP  */
 
 	local_irq_save(flags);
 


  reply	other threads:[~2005-07-28 10:46 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28  9:58 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 10:44 ` Adrian Bunk [this message]
2005-07-28 17:11 ` 2.6.13-rc3-mm3 Christoph Lameter
2005-07-28 19:52   ` 2.6.13-rc3-mm3 Russell King
2005-07-28 20:06     ` 2.6.13-rc3-mm3 Christoph Lameter
2005-07-28 19:11 ` 2.6.13-rc3-mm3 Rafael J. Wysocki
2005-07-28 19:16   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 21:40     ` 2.6.13-rc3-mm3 Rafael J. Wysocki
2005-07-28 23:31       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29  7:06       ` 2.6.13-rc3-mm3 Matthias Urlichs
2005-07-29  9:27         ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 12:01           ` 2.6.13-rc3-mm3 Matthias Urlichs
2005-07-29 14:12           ` Regression hunting with git (was: Re: 2.6.13-rc3-mm3) Matthias Urlichs
2005-07-28 20:34 ` 2.6.13-rc3-mm3 Adrian Bunk
2005-07-28 22:09 ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 20:15   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-28 20:56     ` 2.6.13-rc3-mm3 Nick Sillik
2005-07-28 23:16       ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 20:29   ` 2.6.13-rc3-mm3 Adrian Bunk
2005-07-28 23:29 ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-28 22:02   ` 2.6.13-rc3-mm3 Dirk
2005-07-28 23:46   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 15:48     ` 2.6.13-rc3-mm3 Michael Thonke
     [not found]       ` <42EA4FCC.7030600-S0/GAf8tV78@public.gmane.org>
2005-07-29 19:33         ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 19:33           ` 2.6.13-rc3-mm3 Andrew Morton
     [not found]           ` <20050729123330.2fcfb751.akpm-3NddpPZAyC0@public.gmane.org>
2005-07-30  0:00             ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-30  0:00               ` 2.6.13-rc3-mm3 Michael Thonke
2005-07-29  5:58 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:08   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 15:21     ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29 16:15       ` 2.6.13-rc3-mm3 Eric W. Biederman
2005-07-29  6:01 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:10   ` 2.6.13-rc3-mm3 Andrew Morton
2005-08-03  1:17     ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-08-03  4:21       ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-08-07 23:23         ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29  6:02 ` 2.6.13-rc3-mm3 Martin J. Bligh
2005-07-29 23:05 ` 2.6.13-rc3-mm3 Khalid Aziz
2005-07-29 23:17   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-29 23:17     ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-30 15:33     ` 2.6.13-rc3-mm3 Khalid Aziz
2005-07-30 15:33       ` 2.6.13-rc3-mm3 Khalid Aziz
2005-07-30 18:02       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-30 18:02         ` 2.6.13-rc3-mm3 Andrew Morton
2005-08-01 15:36     ` 2.6.13-rc3-mm3 Bjorn Helgaas
2005-08-01 15:36       ` 2.6.13-rc3-mm3 Bjorn Helgaas
2005-07-30 10:27 ` 2.6.13-rc3-mm3 Richard Purdie
2005-07-30 17:05   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31  9:04 ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31  9:16   ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31 11:12     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 12:46     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 17:35       ` 2.6.13-rc3-mm3 Andrew Morton
2005-07-31 18:21         ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 18:25   ` 2.6.13-rc3-mm3 Linus Torvalds
2005-07-31 18:41     ` 2.6.13-rc3-mm3 Manuel Lauss
2005-07-31 18:59       ` 2.6.13-rc3-mm3 Linus Torvalds
2005-07-31 21:35     ` 2.6.13-rc3-mm3 Stelian Pop
     [not found]     ` <Pine.LNX.4.58.0507311125360.29650@g5.osdl.org>
     [not found]       ` <1122846072.17880.43.camel@deep-space-9.dsnet>
     [not found]         ` <Pine.LNX.4.58.0507311557020.14342@g5.osdl.org>
2005-08-01 14:37           ` 2.6.13-rc3-mm3 Stelian Pop
2005-08-02  9:49             ` 2.6.13-rc3-mm3 Stelian Pop
2005-08-02 10:32               ` 2.6.13-rc3-mm3 Manuel Lauss
2005-08-02 11:40                 ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 14:04                   ` 2.6.13-rc3-mm3 Manuel Lauss
2005-08-02 15:48                   ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 16:50                     ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 17:11                       ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 21:13                         ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 21:21                           ` 2.6.13-rc3-mm3 Greg KH
2005-08-02 21:47                             ` 2.6.13-rc3-mm3 Ivan Kokshaysky
2005-08-02 21:57                               ` 2.6.13-rc3-mm3 Linus Torvalds
2005-08-02 22:59                                 ` [patch 1/2] increase PCIBIOS_MIN_IO on x86 Ivan Kokshaysky
     [not found]                                 ` <Pine.LNX.4.58.0508021456070.3341-hNm40g4Ew95AfugRpC6u6w@public.gmane.org>
2005-08-02 23:09                                   ` [patch 2/2] ACPI: " Ivan Kokshaysky
2005-08-02 23:09                                     ` Ivan Kokshaysky
2005-08-01  1:43 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 16:10   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 20:02     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 20:36       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:07         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 21:16           ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:27             ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 21:40               ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 21:52                 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 22:02                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 22:19                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 23:01                     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-01 23:16                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-01 23:32                         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-04  0:19                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-04 11:27                         ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-04 14:04                           ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-04 14:37                             ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-05 15:17                               ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-07 13:44                                 ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-08 16:48                                   ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-08 17:10                                     ` 2.6.13-rc3-mm3 Russell King
2005-08-08 17:15                                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-08-08 20:40                                     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-08 22:12                                     ` 2.6.13-rc3-mm3 Richard Purdie
2005-08-09  0:57                                       ` 2.6.13-rc3-mm3 Christoph Lameter
2005-09-14 14:32 ` 2.6.13-mm3 and 2.6.14-rc1 both broken (SCSI?) Martin J. Bligh
2005-09-14 14:09   ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050728104439.GE3572@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgooch@atnf.csiro.au \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.