From: Johannes Erdfelt <johannes@erdfelt.com>
To: linux-kernel@vger.kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>
Subject: Re: Linux 2.4.32-pre2
Date: Thu, 28 Jul 2005 17:45:58 -0700 [thread overview]
Message-ID: <20050729004558.GD4817@sventech.com> (raw)
In-Reply-To: <20050728102225.GA7661@dmt.cnet>
On Thu, Jul 28, 2005, Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote:
> diff --git a/drivers/usb/host/uhci.c b/drivers/usb/host/uhci.c
> --- a/drivers/usb/host/uhci.c
> +++ b/drivers/usb/host/uhci.c
> @@ -2924,7 +2924,7 @@ static int alloc_uhci(struct pci_dev *de
> }
>
> /* Only place we don't use the frame list routines */
> - uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle;
> + uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle | UHCI_PTR_QH;
> }
>
> start_hc(uhci);
Am I missing something here? We're certainly adding TDs to the schedule, so
why is this patch setting the QH bit?
JE
prev parent reply other threads:[~2005-07-29 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 8:05 Linux 2.4.32-pre2 Marcelo Tosatti
2005-07-28 9:02 ` Grant Coady
2005-07-28 10:22 ` Marcelo Tosatti
2005-07-29 0:39 ` Grant Coady
2005-07-29 0:45 ` Johannes Erdfelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050729004558.GD4817@sventech.com \
--to=johannes@erdfelt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.