All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 2.6] hwmon: kill cast abuses
Date: Sun, 31 Jul 2005 14:24:27 +0000	[thread overview]
Message-ID: <20050731142354.4baa68ba.khali@linux-fr.org> (raw)
In-Reply-To: <20050729214552.041842e4.khali@linux-fr.org>

Hi Greg, all,

Quoting myself:
> Some hardware monitoring drivers use needless casts to long.
> Especially, three Winbond drivers use many of them. Let's clean this
> up for the sake of code readability, if nothing else.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> 
>  drivers/hwmon/adm1026.c  |    2 +-
>  drivers/hwmon/it87.c     |    4 ++--
>  drivers/hwmon/lm85.c     |    4 ++--
>  drivers/hwmon/w83627hf.c |   29 ++++++++++++++---------------
>  drivers/hwmon/w83781d.c  |   29 ++++++++++++++---------------
>  drivers/hwmon/w83792d.c  |   14 +++++++-------
>  6 files changed, 40 insertions(+), 42 deletions(-)

Please don't apply that patch, it might not be as innocent as it looks.
I don't seem to understand the assembly code changes it causes. I'll
need to have an assembly expert take a look and explain it to me.

Thanks,
-- 
Jean Delvare

      reply	other threads:[~2005-07-31 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-29 21:48 [lm-sensors] [PATCH 2.6] hwmon: kill cast abuses Jean Delvare
2005-07-31 14:24 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050731142354.4baa68ba.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.