From: Adrian Bunk <bunk@stusta.de>
To: dwmw2@infradead.org
Cc: jffs-dev@axis.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] jffs/jffs2: remove wrong function prototypes
Date: Sun, 31 Jul 2005 19:00:29 +0200 [thread overview]
Message-ID: <20050731170029.GC3608@stusta.de> (raw)
This patch removes prototypes for the generic_file_open and
generic_file_llseek functions.
Besides being superfluous because they are already present in fs.h, they
were also wrong because the actual functions aren't weak functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/jffs/inode-v23.c | 3 ---
fs/jffs2/file.c | 3 ---
2 files changed, 6 deletions(-)
--- linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c.old 2005-07-31 18:43:46.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c 2005-07-31 18:44:15.000000000 +0200
@@ -1629,9 +1629,6 @@
}
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *, loff_t, int) __attribute__((weak));
-
static struct file_operations jffs_file_operations =
{
.open = generic_file_open,
--- linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c.old 2005-07-31 18:44:31.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c 2005-07-31 18:44:40.000000000 +0200
@@ -21,9 +21,6 @@
#include <linux/jffs2.h>
#include "nodelist.h"
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) __attribute__((weak));
-
static int jffs2_commit_write (struct file *filp, struct page *pg,
unsigned start, unsigned end);
static int jffs2_prepare_write (struct file *filp, struct page *pg,
next reply other threads:[~2005-07-31 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-31 17:00 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-07 23:13 [2.6 patch] jffs/jffs2: remove wrong function prototypes Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050731170029.GC3608@stusta.de \
--to=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.