All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: John Lenz <lenz@cs.wisc.edu>
Cc: Richard Purdie <rpurdie@rpsys.net>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down
Date: Tue, 2 Aug 2005 00:14:32 +0200	[thread overview]
Message-ID: <20050801221432.GA1413@elf.ucw.cz> (raw)
In-Reply-To: <3059.24.240.41.150.1122931398.squirrel@69.129.69.193>

Hi!

> >> +	/* read comadj */
> >> +#ifdef CONFIG_MACH_POODLE
> >> +	comadj = 118;
> >> +#else
> >> +	comadj = 128;
> >> +#endif
> >
> > Can you go back to the Sharp source and confirm that these values should
> > be hardcoded in both the poodle and collie cases please? I know the
> > sharpsl_param code can provide them but I can't remember exactly which
> > models use which fields. I want to make sure this isn't a quick hack
> > John made before sharpsl_param was written :).
> 
> No, those values were from the original sharp code...  at some point I was
> going to investigate what values the sharpsl param stuff returned and see
> if those worked.  If the sharpsl stuff works, then by all means use it.

I added code to read it from sharpsl, if it is not there, I use
defaults above. It seems to work on my collie.
							Pavel
-- 
teflon -- maybe it is a trademark, but it should not be.

      reply	other threads:[~2005-08-01 22:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27  9:26 [patch] Support powering sharp zaurus sl-5500 LCD up and down Pavel Machek
2005-07-27  9:37 ` Andrew Morton
2005-07-27  9:50   ` Pavel Machek
2005-07-27 10:00     ` Andrew Morton
2005-07-27 10:05       ` Pavel Machek
2005-07-27  9:53   ` Pavel Machek
2005-07-27 10:06     ` Richard Purdie
2005-07-30 13:07       ` Pavel Machek
2005-08-01 21:23       ` John Lenz
2005-08-01 22:14         ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050801221432.GA1413@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.