All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@suse.de>
To: Natasha Jarymowycz <natasha@us.ibm.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: Build break with PAE enabled
Date: Tue, 2 Aug 2005 11:48:27 +0200	[thread overview]
Message-ID: <20050802094827.GC25337@bytesex> (raw)
In-Reply-To: <opsut4ebf2re36p4@ibm-0fo2wxkyoy6.austin.ibm.com>

> Currently x86_32 won't build with PAE enabled.  shadow_public.c needs
> access to functions in shadow32.c.  It looks like shadow_64.h
> includes the needed functionality for x86_64 builds.

Yep, and pae should use these as well.  I've changed a few
places with

	#if CONFIG_PAGING_LEVELS >= 4
	#include <asm/shadow_64.h>
	#endif

to "CONFIG_PAGING_LEVELS >= 3", maybe I forgot to include some
into the patch ...

> Also, shadow_l3_normal_pt_update() was clearly written for x86_64 only.

Yep, no actual code changes for PAE yet, that patch was just the
switchover from the old (shadow32.c) to the new shadow code.
PAE will use the 64bit code as the page table entries 64bit wide
as well.

  Gerd

PS: right now the build fails with "public/acm_ops.h: No such
    file or directory" ...

-- 
panic("it works"); /* avoid being flooded with debug messages */

  reply	other threads:[~2005-08-02  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 15:09 Build break with PAE enabled Natasha Jarymowycz
2005-08-02  9:48 ` Gerd Knorr [this message]
2005-08-02 11:07   ` Gerd Knorr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050802094827.GC25337@bytesex \
    --to=kraxel@suse.de \
    --cc=natasha@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.