From: Andrew Morton <akpm@osdl.org>
To: Doug Maxey <dwm@maxeymade.com>
Cc: jgarzik@pobox.com, olh@suse.de, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] uninline exported ata_host_intr
Date: Fri, 5 Aug 2005 13:10:51 -0700 [thread overview]
Message-ID: <20050805131051.54f333dc.akpm@osdl.org> (raw)
In-Reply-To: <200508051737.j75Hb4s9008109@falcon30.maxeymade.com>
Doug Maxey <dwm@maxeymade.com> wrote:
>
>
> On Fri, 05 Aug 2005 13:10:56 EDT, Jeff Garzik wrote:
> >Olaf Hering wrote:
> >> ata_host_intr cant be either inline or exported.
> >>
> >> Signed-off-by: Olaf Hering <olh@suse.de>
> >>
> >> Index: linux-2.6.12/drivers/scsi/libata-core.c
> >> ===================================================================
> >> --- linux-2.6.12.orig/drivers/scsi/libata-core.c
> >> +++ linux-2.6.12/drivers/scsi/libata-core.c
> >> @@ -3487,7 +3487,7 @@ void ata_bmdma_stop(struct ata_port *ap)
> >> * One if interrupt was handled, zero if not (shared irq).
> >> */
> >>
> >> -inline unsigned int ata_host_intr (struct ata_port *ap,
> >> +unsigned int ata_host_intr (struct ata_port *ap,
> >
> >er, huh?
> >
> >When I wrote this, the compiler did what I expected: it inlined the
> >local copy, and exported a copy for external modules to call.
> >
> >Have you verified the asm does not do this? What changed?
> >
> > Jeff
>
> breaks on ppc64.
>
I don't see why it should break. What the code's trying to do there is
bloaty-but-legitimate.
The function is decared `extern unsigned int ata_host_intr(...)' in .h and
`inline unsigned int ata_host_intr(...)' in .c. Should all work.
Can you share the error messages?
next prev parent reply other threads:[~2005-08-05 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 17:03 [PATCH] uninline exported ata_host_intr Olaf Hering
2005-08-05 17:10 ` Jeff Garzik
2005-08-05 17:15 ` Olaf Hering
2005-08-05 17:30 ` Andrew Vasquez
2005-08-05 17:39 ` Olaf Hering
2005-08-05 17:44 ` Jeff Garzik
2005-08-05 17:37 ` Doug Maxey
2005-08-05 20:10 ` Andrew Morton [this message]
2005-08-05 20:49 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805131051.54f333dc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.