All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: zach@vmware.com
Cc: akpm@osdl.org, chrisl@vmware.com, davej@codemonkey.org.uk,
	hpa@zytor.com, linux-kernel@vger.kernel.org, pavel@suse.cz,
	pratap@vmware.com, Riley@Williams.Name
Subject: Re: [PATCH 1/1] i386 Encapsulate copying of pgd entries
Date: Fri, 5 Aug 2005 18:13:01 -0700	[thread overview]
Message-ID: <20050806011301.GD7991@shell0.pdx.osdl.net> (raw)
In-Reply-To: <200508060026.j760Q6FT025108@zach-dev.vmware.com>

* zach@vmware.com (zach@vmware.com) wrote:
> +	memset(pgd, 0, USER_PTRS_PER_PGD*sizeof(pgd_t));
>  	if (PTRS_PER_PMD == 1)
>  		spin_lock_irqsave(&pgd_lock, flags);
>  
> -	memcpy((pgd_t *)pgd + USER_PTRS_PER_PGD,
> +	clone_pgd_range((pgd_t *)pgd + USER_PTRS_PER_PGD,
>  			swapper_pg_dir + USER_PTRS_PER_PGD,
> -			(PTRS_PER_PGD - USER_PTRS_PER_PGD) * sizeof(pgd_t));
> -
> +			KERNEL_PGD_PTRS);
>  	if (PTRS_PER_PMD > 1)
>  		return;
>  
>  	pgd_list_add(pgd);
>  	spin_unlock_irqrestore(&pgd_lock, flags);
> -	memset(pgd, 0, USER_PTRS_PER_PGD*sizeof(pgd_t));

Why memset was never done on PAE?

thanks,
-chris

  reply	other threads:[~2005-08-06  1:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06  0:26 [PATCH 1/1] i386 Encapsulate copying of pgd entries zach
2005-08-06  1:13 ` Chris Wright [this message]
2005-08-06  1:52   ` Zachary Amsden
2005-08-06  6:00     ` Zachary Amsden
2005-08-06  8:05   ` Zachary Amsden
2005-08-07 19:00 ` Pavel Machek
2005-08-07 19:20   ` Zachary Amsden
2005-08-07 19:37     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050806011301.GD7991@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Riley@Williams.Name \
    --cc=akpm@osdl.org \
    --cc=chrisl@vmware.com \
    --cc=davej@codemonkey.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=pratap@vmware.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.