All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] 8xx: add cpm_get_cpmp()
Date: Sat, 6 Aug 2005 20:27:01 -0300	[thread overview]
Message-ID: <20050806232701.GD1099@dmt.cnet> (raw)
In-Reply-To: <20050806180353.GW5210@cathedrallabs.org>


Aris,

It already is exported, declared as

commproc.h:extern       cpm8xx_t        *cpmp;          /* Pointer to comm processor */


and many drivers use the pointer directly.

arch/ppc/8260_io/ drivers also use the same convention.

Not sure I see much advantage in changing it?

On Sat, Aug 06, 2005 at 03:03:53PM -0300, Aristeu Sergio Rozanski Filho wrote:
> 8xx: add cpm_get_cpmp() to make cpmp visible to modules
> 
> Signed-off-by: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
> 
> Index: 2.6-8xx/arch/ppc/8xx_io/commproc.c
> ===================================================================
> --- 2.6-8xx.orig/arch/ppc/8xx_io/commproc.c	2005-08-03 17:26:05.000000000 -0300
> +++ 2.6-8xx/arch/ppc/8xx_io/commproc.c	2005-08-05 17:13:21.000000000 -0300
> @@ -462,3 +462,10 @@
>  	return ((immap_t *)IMAP_ADDR)->im_cpm.cp_dpmem + offset;
>  }
>  EXPORT_SYMBOL(cpm_dpram_addr);
> +
> +cpm8xx_t *cpm_get_cpmp(void)
> +{
> +	return cpmp;
> +}
> +EXPORT_SYMBOL(cpm_get_cpmp);
> +
> Index: 2.6-8xx/include/asm/commproc.h
> ===================================================================
> --- 2.6-8xx.orig/include/asm/commproc.h	2005-07-28 12:06:51.000000000 -0300
> +++ 2.6-8xx/include/asm/commproc.h	2005-08-05 17:14:28.000000000 -0300
> @@ -78,6 +78,7 @@
>  extern void cpm_dpdump(void);
>  extern void *cpm_dpram_addr(uint offset);
>  extern void cpm_setbrg(uint brg, uint rate);
> +extern cpm8xx_t *cpm_get_cpmp(void);
>  
>  extern uint m8xx_cpm_hostalloc(uint size);
>  extern int  m8xx_cpm_hostfree(uint start);

  reply	other threads:[~2005-08-06 23:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06 18:03 [PATCH] 8xx: add cpm_get_cpmp() Aristeu Sergio Rozanski Filho
2005-08-06 23:27 ` Marcelo Tosatti [this message]
2005-08-06 23:42   ` Aristeu Sergio Rozanski Filho
2005-08-07  0:33     ` Marcelo Tosatti
2005-08-07  3:36     ` Dan Malek
2005-08-07  2:40   ` Dan Malek
2005-08-07  4:31     ` Marcelo Tosatti
2005-08-07 15:39       ` Dan Malek
2005-08-07 15:44         ` Aristeu Sergio Rozanski Filho
2005-08-07 15:57           ` Marcelo Tosatti
2005-08-07 19:18             ` Eugene Surovegin
2005-08-07 17:25           ` Dan Malek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050806232701.GD1099@dmt.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=aris@cathedrallabs.org \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.