From: Adrian Bunk <bunk@stusta.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Achim Leubner <achim_leubner@adaptec.com>
Subject: Re: [PATCH C&C] gdth: remove GDTIOCTL_OSVERS
Date: Mon, 8 Aug 2005 03:40:27 +0200 [thread overview]
Message-ID: <20050808014027.GI4006@stusta.de> (raw)
In-Reply-To: <20050807222829.GA20558@mipter.zuzino.mipt.ru>
On Mon, Aug 08, 2005 at 02:28:29AM +0400, Alexey Dobriyan wrote:
>...
> --- linux-vanilla/drivers/scsi/gdth.c 2005-08-08 02:16:47.000000000 +0400
> +++ linux-gdth/drivers/scsi/gdth.c 2005-08-08 02:19:59.000000000 +0400
> @@ -5411,18 +5411,6 @@ static int gdth_ioctl(struct inode *inod
> return -EFAULT;
> break;
> }
> -
> - case GDTIOCTL_OSVERS:
> - {
> - gdth_ioctl_osvers osv;
> -
> - osv.version = (unchar)(LINUX_VERSION_CODE >> 16);
> - osv.subversion = (unchar)(LINUX_VERSION_CODE >> 8);
> - osv.revision = (ushort)(LINUX_VERSION_CODE & 0xff);
> - if (copy_to_user(argp, &osv, sizeof(gdth_ioctl_osvers)))
> - return -EFAULT;
> - break;
> - }
>...
Not that I'd like this, but you know that this is a userspace-visible
change?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-08-08 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-07 22:28 [PATCH C&C] gdth: remove GDTIOCTL_OSVERS Alexey Dobriyan
2005-08-08 1:40 ` Adrian Bunk [this message]
2005-08-08 10:33 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050808014027.GI4006@stusta.de \
--to=bunk@stusta.de \
--cc=James.Bottomley@SteelEye.com \
--cc=achim_leubner@adaptec.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.