All of lore.kernel.org
 help / color / mirror / Atom feed
From: domen@coderock.org
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org,
	Nishanth Aravamudan <nacc@us.ibm.com>,
	domen@coderock.org
Subject: [patch 16/16] block/ps2esdi: replace sleep_on() with wait_event()
Date: Tue, 09 Aug 2005 00:29:52 +0200	[thread overview]
Message-ID: <20050808223100.045700000@homer> (raw)
In-Reply-To: 20050808222936.090422000@homer

[-- Attachment #1: wait_event-drivers_block_ps2esdi.patch --]
[-- Type: text/plain, Size: 1519 bytes --]

From: Nishanth Aravamudan <nacc@us.ibm.com>



Use wait_event() instead of the deprecated sleep_on(). In all
replacements, wait_event() expects the condition to *stop* on, so the existing
conditional is negated and passed as the parameter. I am not sure if these
changes are appropriate, as the condition to pass to wait_event() to guarantee
the same behavior; I think this is the best choice, though.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 ps2esdi.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Index: quilt/drivers/block/ps2esdi.c
===================================================================
--- quilt.orig/drivers/block/ps2esdi.c
+++ quilt/drivers/block/ps2esdi.c
@@ -43,6 +43,7 @@
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/module.h>
+#include <linux/delay.h>
 
 #include <asm/system.h>
 #include <asm/io.h>
@@ -461,8 +462,7 @@ static void __init ps2esdi_get_device_cf
 	cmd_blk[1] = 0;
 	no_int_yet = TRUE;
 	ps2esdi_out_cmd_blk(cmd_blk);
-	if (no_int_yet)
-		sleep_on(&ps2esdi_int);
+	wait_event(ps2esdi_int, !no_int_yet);
 
 	if (ps2esdi_drives > 1) {
 		printk("%s: Drive 1\n", DEVICE_NAME);	/*BA */
@@ -470,8 +470,7 @@ static void __init ps2esdi_get_device_cf
 		cmd_blk[1] = 0;
 		no_int_yet = TRUE;
 		ps2esdi_out_cmd_blk(cmd_blk);
-		if (no_int_yet)
-			sleep_on(&ps2esdi_int);
+		wait_event(ps2esdi_int, !no_int_yet);
 	}			/* if second physical drive is present */
 	return;
 }

--

  parent reply	other threads:[~2005-08-08 22:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08 22:29 [patch 00/16] old kernel janitor patches domen
2005-08-08 22:29 ` [patch 01/16] ide: min/max macros in ide-timing.h domen
2005-08-08 22:29 ` [patch 02/16] net/ppp-generic: list_for_each_entry domen
2005-08-08 22:29 ` [patch 03/16] jffs/intrep: list_for_each_entry domen
2005-08-08 22:29 ` [patch 04/16] fs/namespace.c: list_for_each_entry domen
2005-08-08 22:29 ` [patch 05/16] fs/dcache.c: list_for_each* domen
2005-08-08 22:29 ` [patch 06/16] ide-tape: replace schedule_timeout() with msleep() domen
2005-08-08 22:29 ` [patch 07/16] block/umem: replace PRINTK with pr_debug domen
2005-08-08 22:29 ` [patch 08/16] tulip/de4x5: list_for_each domen
2005-08-08 22:29 ` [patch 09/16] sh: bigsur/io: minmax-removal domen
2005-08-08 22:29 ` [patch 10/16] sh: hd64465: minmax-removal domen
2005-08-08 22:29 ` [patch 11/16] block/xd: replace schedule_timeout() with msleep()/msleep_interruptible() domen
2005-08-08 22:29 ` [patch 12/16] ide/ide-cs: replace schedule_timeout() with msleep() domen
2005-08-08 22:29 ` [patch 13/16] net/stir4200: replace direct assignment with set_current_state() domen
2005-08-08 22:29 ` [patch 14/16] net/tms380tr: " domen
2005-08-11  3:19   ` Jeff Garzik
2005-08-11  3:27     ` Nishanth Aravamudan
2005-08-08 22:29 ` [patch 15/16] reiserfs: super.c - vfree() checking cleanups domen
2005-08-08 22:29 ` domen [this message]
2005-08-09  6:14   ` [patch 16/16] block/ps2esdi: replace sleep_on() with wait_event() Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050808223100.045700000@homer \
    --to=domen@coderock.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nacc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.