From: Dave Jones <davej@redhat.com>
To: linux-parport@lists.infradead.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Incorrect permissions on parport sysctls.
Date: Tue, 9 Aug 2005 00:44:41 -0400 [thread overview]
Message-ID: <20050809044440.GA7725@redhat.com> (raw)
We have a bunch of 'probe' sysctl's in parport, which are
readable. (world readable even). Make them write-only.
Without this, sysctl -a will try to read these files.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.11/drivers/parport/procfs.c~ 2005-04-25 12:17:30.000000000 -0400
+++ linux-2.6.11/drivers/parport/procfs.c 2005-04-25 12:20:35.000000000 -0400
@@ -286,19 +286,19 @@ static const struct parport_sysctl_table
PARPORT_DEVICES_ROOT_DIR,
#ifdef CONFIG_PARPORT_1284
{ DEV_PARPORT_AUTOPROBE, "autoprobe",
- NULL, 0, 0444, NULL,
+ NULL, 0, 0200, NULL,
&do_autoprobe },
{ DEV_PARPORT_AUTOPROBE + 1, "autoprobe0",
- NULL, 0, 0444, NULL,
+ NULL, 0, 0200, NULL,
&do_autoprobe },
{ DEV_PARPORT_AUTOPROBE + 2, "autoprobe1",
- NULL, 0, 0444, NULL,
+ NULL, 0, 0200, NULL,
&do_autoprobe },
{ DEV_PARPORT_AUTOPROBE + 3, "autoprobe2",
- NULL, 0, 0444, NULL,
+ NULL, 0, 0200, NULL,
&do_autoprobe },
{ DEV_PARPORT_AUTOPROBE + 4, "autoprobe3",
- NULL, 0, 0444, NULL,
+ NULL, 0, 0200, NULL,
&do_autoprobe },
#endif /* IEEE 1284 support */
{0}
next reply other threads:[~2005-08-09 4:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 4:44 Dave Jones [this message]
2005-08-09 7:10 ` Incorrect permissions on parport sysctls Jan Engelhardt
2005-08-09 10:11 ` [Linux-parport] " Tim Waugh
2005-08-09 15:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050809044440.GA7725@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.