All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: sparclinux@vger.kernel.org
Subject: [PATCH] remove ifdef CONFIG_PCI from envctrl.c
Date: Tue, 09 Aug 2005 20:31:19 +0000	[thread overview]
Message-ID: <20050809203118.GA28805@lst.de> (raw)

The driver already depends on CONFIG_PCI in Kconfig.  What I don't quite
understand yet is why a PCI-only driver sits in drivers/sbus/ ..


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/drivers/sbus/char/envctrl.c
=================================--- linux-2.6.orig/drivers/sbus/char/envctrl.c	2005-08-09 20:16:59.000000000 +0200
+++ linux-2.6/drivers/sbus/char/envctrl.c	2005-08-09 22:29:45.000000000 +0200
@@ -1041,7 +1041,6 @@
 
 static int __init envctrl_init(void)
 {
-#ifdef CONFIG_PCI
 	struct linux_ebus *ebus = NULL;
 	struct linux_ebus_device *edev = NULL;
 	struct linux_ebus_child *edev_child = NULL;
@@ -1133,9 +1132,6 @@
 			kfree(i2c_childlist[i].tables);
 	}
 	return err;
-#else
-	return -ENODEV;
-#endif
 }
 
 static void __exit envctrl_cleanup(void)

             reply	other threads:[~2005-08-09 20:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-09 20:31 Christoph Hellwig [this message]
2005-08-09 21:38 ` [PATCH] remove ifdef CONFIG_PCI from envctrl.c David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050809203118.GA28805@lst.de \
    --to=hch@lst.de \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.