From: Christoph Hellwig <hch@lst.de>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: tasklist_lock abuse in ipt{,6}owner
Date: Thu, 11 Aug 2005 17:24:50 +0200 [thread overview]
Message-ID: <20050811152450.GA8189@lst.de> (raw)
In-Reply-To: <42FB449A.7030709@trash.net>
On Thu, Aug 11, 2005 at 02:29:14PM +0200, Patrick McHardy wrote:
> Christoph Hellwig wrote:
> > Folks, could you please take a look at getting rid of that match_pid
> > crap? We need to get rid of the tasklist_lock export to change the
> > locking scheme in that area, and what netfilter does with it is not
> > pretty. I'd actually prefer dropping those modules completely, this
> > kind of inverse lookup from file/socket to process shouldn't be done
> > anywhere in the kernel.
>
> I think its ok to rip out cmd/sid/pid matching, it is broken and can't
> be fixed anyway. Feel free to send a patch, otherwise I'll take care
> of it.
So you want to keep the uid/gid matches for now? Probably we should
check for the others in ->checkentry then and refuse to load if they're
present?
next prev parent reply other threads:[~2005-08-11 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 21:12 tasklist_lock abuse in ipt{,6}owner Christoph Hellwig
2005-08-11 12:29 ` Patrick McHardy
2005-08-11 15:24 ` Christoph Hellwig [this message]
2005-08-11 15:29 ` Christoph Hellwig
2005-08-12 13:03 ` Patrick McHardy
2005-08-11 12:30 ` Doubt in kernel packet generation varun
2005-08-12 11:43 ` Pablo Neira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811152450.GA8189@lst.de \
--to=hch@lst.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.