All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Bolke de Bruin <bdbruin@aub.nl>
Subject: Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA
Date: Thu, 11 Aug 2005 18:19:38 +0200	[thread overview]
Message-ID: <200508111819.45325@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <42FB72DE.8000703@aub.nl>

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Bolke de Bruin wrote:
>So the basic question is. Does this controller work on kernel 2.6.5?

The problem is that the default stack size was reduced to 4kB. The local 
arrays allocated by the driver eat 2kB each, so a stack overflow is very 
likely. Even with 8kB stack it is still not impossible. Using the version 
from 2.6.5 will not be a very good idea I think, it's likely to crash your 
machine one day.

The right solution would be fixing the driver to use kmalloc()/kfree() when he 
really needs the memory. There was a patch only a few days ago that tried to 
do that, but it was not really well done and would have crashed. If you are 
really interested in I can do such a patch. The code of this driver sucks 
universes through nanotubes, but one day someone _will_ have to start 
cleaning this up.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2005-08-11 16:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-11 15:46 Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA Bolke de Bruin
2005-08-11 15:51 ` Arjan van de Ven
2005-08-11 16:19 ` Rolf Eike Beer [this message]
2005-08-11 16:41   ` Bolke de Bruin
2005-08-11 16:58     ` Rolf Eike Beer
2005-08-11 17:58 ` Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA [PATCH] Rolf Eike Beer
     [not found] ` <200508160955.49133@bilbo.math.uni-mannheim.de>
     [not found]   ` <4301A6BB.3020403@aub.nl>
2005-08-16  8:58     ` Rolf Eike Beer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200508111819.45325@bilbo.math.uni-mannheim.de \
    --to=eike-kernel@sf-tec.de \
    --cc=bdbruin@aub.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.