From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Patrick Mochel <mochel@digitalimplant.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Don't use a klist for drivers' set-of-devices
Date: Thu, 11 Aug 2005 19:53:32 +0100 [thread overview]
Message-ID: <20050811185332.GA6870@infradead.org> (raw)
In-Reply-To: <20050811182423.GC15803@kroah.com>
On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote:
> > This patch (as536) simplifies the driver-model core by replacing the klist
> > used to store the set of devices bound to a driver with a regular list
> > protected by a mutex. It turns out that even with a klist, there are too
> > many opportunities for races for the list to be used safely by more than
> > one thread at a time. And given that only one thread uses the list at any
> > moment, there's no need to add all the extra overhead of making it a
> > klist.
>
> Hm, but that was the whole reason to go to a klist in the first place.
And shows once more that the klist approach was totally misguided.
next prev parent reply other threads:[~2005-08-11 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-10 20:56 [PATCH] Don't use a klist for drivers' set-of-devices Alan Stern
2005-08-11 18:24 ` Greg KH
2005-08-11 18:53 ` Christoph Hellwig [this message]
2005-08-11 19:43 ` Alan Stern
2005-08-11 20:29 ` Dmitry Torokhov
2005-08-11 20:52 ` Alan Stern
2005-08-12 13:48 ` Alan Stern
2005-08-15 21:21 ` Alan Stern
2005-08-16 22:34 ` Dmitry Torokhov
2005-08-17 13:55 ` Alan Stern
2005-08-17 14:33 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050811185332.GA6870@infradead.org \
--to=hch@infradead.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.