diff for duplicates of <20050812080210.58573fe3.khali@linux-fr.org> diff --git a/a/1.txt b/N1/1.txt index c67aafe..1faa8dd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ possibly take a look at the i2c-viapro driver and comment on that part: if ((pci_read_config_word(pdev, id->driver_data, &vt596_smba)) || !(vt596_smba & 0x1)) { /* try 2nd address and config reg. for 596 */ - if (id->device = PCI_DEVICE_ID_VIA_82C596_3 && + if (id->device == PCI_DEVICE_ID_VIA_82C596_3 && !pci_read_config_word(pdev, SMBBA2, &vt596_smba) && (vt596_smba & 0x1)) { smb_cf_hstcfg = 0x84; @@ -42,8 +42,8 @@ Alright, it matches the datasheet and my expectations. > the i2c-viapro is a polling driver, it becomes slower as HZ decreases. Absolutely true. This is what improved the speed of most SMBus drivers -in 2.6 when compared with 2.4: HZ\x1000. Now we're stepping back a bit -with HZ%0. +in 2.6 when compared with 2.4: HZ=1000. Now we're stepping back a bit +with HZ=250. > I.e. the improvement you are seeing with byte vs. block xfers is quite > exaggerated because we poll the device relatively infrequently. *All* diff --git a/a/content_digest b/N1/content_digest index cadaacb..e29eb07 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020050809231328.0726537b.khali@linux-fr.org\0" "ref\020050812010759.GA11361@jupiter.solarsys.private\0" - "From\0khali@linux-fr.org (Jean Delvare)\0" - "Subject\0[lm-sensors] I2C block reads with i2c-viapro: testers wanted\0" - "Date\0Fri, 12 Aug 2005 08:02:09 +0000\0" + "From\0Jean Delvare <khali@linux-fr.org>\0" + "Subject\0Re: [lm-sensors] I2C block reads with i2c-viapro: testers wanted\0" + "Date\0Fri, 12 Aug 2005 08:02:10 +0200\0" "To\0Mark M. Hoffman <mhoffman@lightlink.com>\0" "Cc\0LM Sensors <lm-sensors@lm-sensors.org>" " LKML <linux-kernel@vger.kernel.org>\0" @@ -28,7 +28,7 @@ "\tif ((pci_read_config_word(pdev, id->driver_data, &vt596_smba)) ||\n" "\t !(vt596_smba & 0x1)) {\n" "\t\t/* try 2nd address and config reg. for 596 */\n" - "\t\tif (id->device = PCI_DEVICE_ID_VIA_82C596_3 &&\n" + "\t\tif (id->device == PCI_DEVICE_ID_VIA_82C596_3 &&\n" "\t\t !pci_read_config_word(pdev, SMBBA2, &vt596_smba) &&\n" "\t\t (vt596_smba & 0x1)) {\n" "\t\t\tsmb_cf_hstcfg = 0x84;\n" @@ -52,8 +52,8 @@ "> the i2c-viapro is a polling driver, it becomes slower as HZ decreases.\n" "\n" "Absolutely true. This is what improved the speed of most SMBus drivers\n" - "in 2.6 when compared with 2.4: HZ\02000. Now we're stepping back a bit\n" - "with HZ%0.\n" + "in 2.6 when compared with 2.4: HZ=1000. Now we're stepping back a bit\n" + "with HZ=250.\n" "\n" "> I.e. the improvement you are seeing with byte vs. block xfers is quite\n" "> exaggerated because we poll the device relatively infrequently. *All*\n" @@ -81,4 +81,4 @@ "-- \n" Jean Delvare -b57fa5c5c7cfd4f6bfbd140e4825df3cd60547600916e37230038dd3a4d325b5 +685448d1b77452df64d80343a212b74fcc1df06e59f6950a982ea1a7b30f26a1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.