Re: APIC version and 8-bit APIC IDs

["Siddha, Suresh B" <suresh.b.siddha@intel.com>]

On Fri, Aug 12, 2005 at 08:22:28PM +0200, Andi Kleen wrote:
> > --- linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c~	2005-08-12 10:19:07.037696416 -0700
> > +++ linux-2.6.13-rc6/arch/x86_64/kernel/mpparse.c	2005-08-12 10:19:38.098974384 -0700
> > @@ -707,7 +707,7 @@
> >  
> >  	processor.mpc_type = MP_PROCESSOR;
> >  	processor.mpc_apicid = id;
> > -	processor.mpc_apicver = 0x10; /* TBD: lapic version */
> > +	processor.mpc_apicver = GET_APIC_VERSION(apic_read(APIC_LVR));
> 
> That code executes on the BP. What happens when different CPUs have
> different APIC versions?  Not sure if that can happen, but it 
> still looks a bit like "cheating.

Not sure if we ever support CPUs with different APIC versions. That will
probably require some ACPI SPEC changes too..

I would say, for now just follow the i386 code.

thanks,
suresh