From: Ralf Baechle <ralf@linux-mips.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: netdev@oss.sgi.com
Subject: Re: Strange uses of netif_start_queue
Date: Fri, 12 Aug 2005 14:39:05 +0100 [thread overview]
Message-ID: <20050812133905.GF2819@linux-mips.org> (raw)
In-Reply-To: <20050812132758.GE2819@linux-mips.org>
On Fri, Aug 12, 2005 at 02:27:59PM +0100, Ralf Baechle wrote:
> > Something I noticed doing the tty work. the 6pack driver calls
> > netif_start_queue() before it calls register_netdev. I'm curious if this
> > is allowed ?
>
> As part of adding support for extended 6pack which is required by the
> PR 430 I've recently fixed that. It was looking suspect enough that I
> fixed it though I don't see any way this could do harm.
To answer the fundamental question, I think netif_start_queue /
netif_stop_queue should be allowed in case the driver for some reason has
the desire to stop queueing of packet immediately after register_netdev.
Ralf
next prev parent reply other threads:[~2005-08-12 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 13:35 Strange uses of netif_start_queue Alan Cox
2005-08-12 13:27 ` Ralf Baechle
2005-08-12 13:39 ` Ralf Baechle [this message]
2005-08-12 18:03 ` David S. Miller
2005-08-12 13:33 ` Patrick McHardy
2005-08-12 18:00 ` David S. Miller
2005-08-12 18:46 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812133905.GF2819@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.