From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@suse.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] fix ucb1x00 support on collie
Date: Fri, 12 Aug 2005 20:49:46 +0100 [thread overview]
Message-ID: <20050812204946.D21152@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050812111103.GD1826@elf.ucw.cz>; from pavel@suse.cz on Fri, Aug 12, 2005 at 01:11:03PM +0200
On Fri, Aug 12, 2005 at 01:11:03PM +0200, Pavel Machek wrote:
> You still do:
>
> Ser4MCCR0 = data->mccr0 | 0x7f7f;
>
> ...I'm not sure, but it seems to me I want MMCR0 to be set to
> 0x60000. Would it be better to move 7f7f constant (what is it, anyway)
> to machine-specific code?
I do this because we want the MCP bus running at the lowest sample
speed initially. When the drivers have initialised, they will call
mcp_sa1100_set_telecom_divisor() and mcp_sa1100_set_audio_divisor()
to set these fields appropriately.
They aren't machine specific.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-08-12 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-31 13:46 [patch] fix ucb1x00 support on collie Pavel Machek
2005-07-31 15:42 ` Russell King
2005-08-07 14:08 ` Russell King
2005-08-12 11:11 ` Pavel Machek
2005-08-12 19:49 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050812204946.D21152@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.