From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1E3y4w-0001vx-EW
	for qemu-devel@nongnu.org; Sat, 13 Aug 2005 11:37:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1E3y4u-0001vi-Vv
	for qemu-devel@nongnu.org; Sat, 13 Aug 2005 11:37:46 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1E3y2z-0000oH-Pr
	for qemu-devel@nongnu.org; Sat, 13 Aug 2005 11:35:45 -0400
Received: from [65.74.133.11] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtp
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1E3xr5-00059C-Ue
	for qemu-devel@nongnu.org; Sat, 13 Aug 2005 11:23:28 -0400
From: Paul Brook <paul@codesourcery.com>
Date: Sat, 13 Aug 2005 16:08:03 +0100
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200508131608.04067.paul@codesourcery.com>
Subject: [Qemu-devel] [patch] Byte swapping bug in arm semihosting
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

The patch below fixes a duplicate byte swap in the arm semihosting 
implementation. ARG(x) already does the endian correction.

Paul
Index: linux-user//arm-semi.c
===================================================================
RCS file: /cvsroot/qemu/qemu/linux-user/arm-semi.c,v
retrieving revision 1.3
diff -u -p -r1.3 arm-semi.c
--- linux-user//arm-semi.c	13 May 2005 22:42:37 -0000	1.3
+++ linux-user//arm-semi.c	13 Aug 2005 15:05:30 -0000
@@ -178,7 +178,7 @@ uint32_t do_arm_semihosting(CPUState *en
                 ts->heap_limit = limit;
             }
               
-            ptr = (uint32_t *)tswap32(ARG(0));
+            ptr = (uint32_t *)ARG(0);
             ptr[0] = tswap32(ts->heap_base);
             ptr[1] = tswap32(ts->heap_limit);
             ptr[2] = tswap32(ts->stack_base);