From: Christoph Hellwig <hch@infradead.org>
To: Pascal Terjan <pterjan@mandriva.com>
Cc: linux-scsi@vger.kernel.org, sreenib@lsil.com, sju@lsil.com
Subject: Re: [PATCH] allow building both megaraid and megraid_mbox
Date: Mon, 15 Aug 2005 11:15:35 +0100 [thread overview]
Message-ID: <20050815101535.GA590@infradead.org> (raw)
In-Reply-To: <1123934582.8173.29.camel@plop>
On Sat, Aug 13, 2005 at 02:03:01PM +0200, Pascal Terjan wrote:
> Hello,
> here is a small patch that allow building both drivers by removing the
> devices supported by the new driver from the id_table of the old driver
> when you want both.
> It is usefull for distributions wanting to keep supporting legacy
> hardware.
>
> What's you opinion about that problem and the fix ?
Given that the new megaraid_mbox driver works nicely I suggest to:
- remove all but the two PCI ids not support by megaraid_mbox from
the old driver
- rename the old module to megaraid_legacy so people don't use it by
accident
- remove all code dealing with more recent controllers from the old
driver. Unfortunately the checks for different types of hardware
are implicit in the driver and not keyed of the PCI IDs.
Sreenivas and Seokmann, could you help us with identifying the codepathes
only used by recent hardware that we can remove from the legacy driver?
prev parent reply other threads:[~2005-08-15 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-13 12:03 [PATCH] allow building both megaraid and megraid_mbox Pascal Terjan
2005-08-15 10:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050815101535.GA590@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pterjan@mandriva.com \
--cc=sju@lsil.com \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.