From: Greg Edwards <edwardsg@sgi.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH] Fix mmap_kmem (was: [question] What's the difference between /dev/kmem and /dev/mem)
Date: Tue, 16 Aug 2005 17:12:23 -0500 [thread overview]
Message-ID: <20050816221223.GA9991@sgi.com> (raw)
In-Reply-To: <1123957087.3187.31.camel@laptopd505.fenrus.org>
On Sat, Aug 13, 2005 at 08:18:07PM +0200, Arjan van de Ven wrote:
| On Sat, 2005-08-13 at 10:37 -0700, Linus Torvalds wrote:
| > Actually, the more I looked at that mmap_kmem() function, the less I liked
| > it. Let's get that sucker fixed better first. It's still not wonderful,
| > but at least now it tries to verify the whole _range_ of the mapping.
|
| actually if that is your goal this just isn't enough... assume the
| situation of a 1 page "forbidden gap", if you mmap 3 pages with the gap
| in the middle.... then the code you send still doesn't cope. At which
| point... it gets messy...
mmap_mem suffers from a lack of proper checks as well. For example, on
Altix page 0 of each node is reserved for prom and a read or write to it
will cause an MCA. mmaping /dev/mem with offset 0 will nicely explode.
Would adding a pfn_valid test in mmap_mem be the best bet, or could we
consolidate the checks currently in mmap_kmem into mmap_mem?
Greg
next prev parent reply other threads:[~2005-08-16 22:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 21:36 [question] What's the difference between /dev/kmem and /dev/mem Steven Rostedt
2005-08-12 1:15 ` [PATCH] Fix mmap_kmem (was: [question] What's the difference between /dev/kmem and /dev/mem) Steven Rostedt
2005-08-12 14:25 ` Hugh Dickins
2005-08-12 16:35 ` Linus Torvalds
2005-08-12 16:56 ` Dave Jones
2005-08-12 17:07 ` Steven Rostedt
2005-08-12 17:16 ` Arjan van de Ven
2005-08-12 17:32 ` Steven Rostedt
2005-08-12 17:01 ` Steven Rostedt
2005-08-13 13:39 ` [PATCH] Fix mmap kmem " Nicolas George
2005-08-13 16:50 ` [PATCH] Fix mmap_kmem " Arjan van de Ven
2005-08-13 16:56 ` Linus Torvalds
2005-08-13 17:25 ` Arjan van de Ven
2005-08-13 17:37 ` Linus Torvalds
2005-08-13 18:18 ` Arjan van de Ven
2005-08-16 22:12 ` Greg Edwards [this message]
2005-08-16 23:33 ` Alan Cox
2005-08-16 23:47 ` Steven Rostedt
2005-08-15 19:33 ` Olaf Hering
2005-08-15 21:14 ` Jeff Dike
2005-08-15 21:50 ` Olaf Hering
2005-08-15 22:41 ` Linus Torvalds
2005-08-16 1:16 ` Steven Rostedt
2005-08-16 1:22 ` Steven Rostedt
2005-08-16 1:36 ` Linus Torvalds
2005-08-13 16:57 ` Joshua Hudson
2005-08-13 17:27 ` Arjan van de Ven
2005-08-14 14:50 ` Martin J. Bligh
2005-08-18 14:07 ` Arjan van de Ven
2005-08-18 14:18 ` Steven Rostedt
[not found] <1123796188.17269.127.camel@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <1123809302.17269.139.camel@localhost.localdomain.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.58.0508120930150.3295@g5.osdl.org.suse.lists.linux.kernel>
2005-08-12 16:54 ` Andi Kleen
2005-08-12 17:56 ` Arjan van de Ven
2005-08-12 18:26 ` Andi Kleen
2005-08-13 9:56 ` Ingo Oeser
2005-08-13 12:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050816221223.GA9991@sgi.com \
--to=edwardsg@sgi.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=steiner@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.