From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750750AbVHPXwO (ORCPT ); Tue, 16 Aug 2005 19:52:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750754AbVHPXwO (ORCPT ); Tue, 16 Aug 2005 19:52:14 -0400 Received: from smtp.osdl.org ([65.172.181.4]:41367 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750750AbVHPXwN (ORCPT ); Tue, 16 Aug 2005 19:52:13 -0400 Date: Tue, 16 Aug 2005 16:52:00 -0700 From: Chris Wright To: Andi Kleen Cc: zach@vmware.com, akpm@osdl.org, chrisl@vmware.com, chrisw@osdl.org, hpa@zytor.com, Keir.Fraser@cl.cam.ac.uk, linux-kernel@vger.kernel.org, m+Ian.Pratt@cl.cam.ac.uk, mbligh@mbligh.org, pratap@vmware.com, virtualization@lists.osdl.org, zwame@arm.linux.org.uk Subject: Re: [PATCH 4/14] i386 / Clean up asm and volatile keywords in desc Message-ID: <20050816235200.GS7762@shell0.pdx.osdl.net> References: <200508110453.j7B4rpe9019530@zach-dev.vmware.com> <20050816234205.GE27628@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050816234205.GE27628@wotan.suse.de> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen (ak@suse.de) wrote: > On Wed, Aug 10, 2005 at 09:53:51PM -0700, zach@vmware.com wrote: > > Stop using extra underscores on asm and volatiles, that is just silly. > > Actually the volatiles might be still useful. Or if you drop them > at least add memory clobbers. They are still there, just the underscores on both asm and volatile got pulled. > I had sometimes bugs on x86-64 > with the compiler moving such assembly statements with invisible > side effects around too aggressively and causing weird problems. > > Agreed on the underscores, I hate them too :) Heh, same here ;-) thanks, -chris