From: Chris Wright <chrisw@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: Chris Wright <chrisw@osdl.org>,
zach@vmware.com, akpm@osdl.org, chrisl@vmware.com, hpa@zytor.com,
Keir.Fraser@cl.cam.ac.uk, linux-kernel@vger.kernel.org,
m+Ian.Pratt@cl.cam.ac.uk, mbligh@mbligh.org, pratap@vmware.com,
virtualization@lists.osdl.org, zwane@arm.linux.org.uk
Subject: Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor
Date: Tue, 16 Aug 2005 17:24:37 -0700 [thread overview]
Message-ID: <20050817002437.GX7762@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050817001635.GC3996@wotan.suse.de>
* Andi Kleen (ak@suse.de) wrote:
> On Tue, Aug 16, 2005 at 05:07:36PM -0700, Chris Wright wrote:
> > * Andi Kleen (ak@suse.de) wrote:
> > > On Wed, Aug 10, 2005 at 09:56:40PM -0700, zach@vmware.com wrote:
> > > > Add an accessor function for getting the per-CPU gdt. Callee must already
> > > > have the CPU.
> > >
> > > What is the accessor good for?
> > >
> > > It looks just like code obfuscation to me.
> >
> > Xen handles gdt differently (one page per cpu instead of per_cpu data).
> > So this is for handling that access cleanly.
>
> It would be much cleaner to use a per_cpu pointer then and just allocate
> it differently.
OK, that's easily done, but it will add extra indirection. This currently
changes nothing for common case. The cpu_gdt_descr effectively has that
address cached already (just not as per_cpu).
prev parent reply other threads:[~2005-08-17 0:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 4:56 [PATCH 8/14] i386 / Add a per cpu gdt accessor zach
2005-08-11 5:45 ` Zwane Mwaikambo
2005-08-11 5:40 ` Chris Wright
2005-08-11 5:43 ` H. Peter Anvin
2005-08-11 5:54 ` Chris Wright
2005-08-11 5:53 ` Zachary Amsden
2005-08-11 6:06 ` Zwane Mwaikambo
2005-08-16 23:47 ` Andi Kleen
2005-08-16 23:49 ` H. Peter Anvin
2005-08-17 0:07 ` Chris Wright
2005-08-17 0:16 ` Andi Kleen
2005-08-17 0:24 ` Chris Wright [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050817002437.GX7762@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chrisl@vmware.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=mbligh@mbligh.org \
--cc=pratap@vmware.com \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.