From: "Gabriel A. Devenyi" <ace@staticwave.ca>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] remove unused return in drivers/block/pktcdvd.c
Date: Thu, 18 Aug 2005 01:28:32 +0000 [thread overview]
Message-ID: <200508172128.32202.ace@staticwave.ca> (raw)
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com) if anyone else is interested, you can ask
for a login at linuxbugs@coverity.com.
The function pkt_iosched_process_queue makes a call to bdev_get_queue and stores the result but never uses it, so
it looks like it can be safely removed.
This patch applies to linus' latest Git tree 099d44e869f1886b5eb02a5145ca97b5e4142e28.
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -501,14 +501,11 @@ static void pkt_queue_bio(struct pktcdvd
*/
static void pkt_iosched_process_queue(struct pktcdvd_device *pd)
{
- request_queue_t *q;
if (atomic_read(&pd->iosched.attention) == 0)
return;
atomic_set(&pd->iosched.attention, 0);
- q = bdev_get_queue(pd->bdev);
-
for (;;) {
struct bio *bio;
int reads_queued, writes_queued;
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-08-18 1:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508172128.32202.ace@staticwave.ca \
--to=ace@staticwave.ca \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.