From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: [PATCH] patches: workaround for br_del_if race Date: Thu, 18 Aug 2005 16:01:34 -0500 Message-ID: <20050818210134.GG10593@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Kip Macy List-Id: xen-devel@lists.xenproject.org This patch provides a workaround for bugzilla #90 which shows up far too often when creating and then destroying lots of domUs and dom0 is SMP. Details are in the [1]bug. With this patch, I now can create/destroy domains in a tight loop for hours where previously every 3 to 10 cycles would blow up. Please apply. 1. http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=90 -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com diffstat output: workaround_double_br_del_if.patch | 11 +++++++++++ 1 files changed, 11 insertions(+) Signed-off-by: Ryan Harper --- diff -r dfbeb7da829f patches/linux-2.6.12/workaround_double_br_del_if.patch --- /dev/null Thu Aug 18 19:51:46 2005 +++ b/patches/linux-2.6.12/workaround_double_br_del_if.patch Thu Aug 18 15:53:37 2005 @@ -0,0 +1,11 @@ +--- linux-2.6.12/net/bridge/br_if.c 2005-06-17 14:48:29.000000000 -0500 ++++ linux-2.6.12-xen0-smp/net/bridge/br_if.c 2005-08-18 15:17:27.302615846 -0500 +@@ -382,7 +382,7 @@ + { + struct net_bridge_port *p = dev->br_port; + +- if (!p || p->br != br) ++ if (!p || p->br != br || p->state == BR_STATE_DISABLED) + return -EINVAL; + + br_sysfs_removeif(p);