From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E5vGf-00056i-N1 for mharc-grub-devel@gnu.org; Thu, 18 Aug 2005 21:01:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E5vGX-000524-Kh for grub-devel@gnu.org; Thu, 18 Aug 2005 21:01:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E5vGS-0004zZ-6f for grub-devel@gnu.org; Thu, 18 Aug 2005 21:01:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E5vGR-0004QX-EV for grub-devel@gnu.org; Thu, 18 Aug 2005 21:01:43 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E5vL6-0007r8-Kl for grub-devel@gnu.org; Thu, 18 Aug 2005 21:06:32 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 7170D11F22F0A for ; Fri, 19 Aug 2005 02:49:55 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 19 Aug 05 00:49:55 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 19 Aug 2005 02:48:38 +0200 User-Agent: KMail/1.7.2 References: <42FF3097.7030904@nic.fi> <200508141648.00325.okuji@enbug.org> In-Reply-To: <200508141648.00325.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200508190248.38363.okuji@enbug.org> Subject: Re: vesafb terminal for testing. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2005 01:01:53 -0000 On Sunday 14 August 2005 16:48, Yoshinori K. Okuji wrote: > On Sunday 14 August 2005 13:52, Vesa J=E4=E4skel=E4inen wrote: > > I have attached patch here that adds simple terminal that uses VESA BIOS > > Extension 2.0+ for rendering terminal. It is not meant to be included as > > is in GRUB 2, but I would hope that people would test it, so I could try > > to improve it for greater compatibility (even though I have tried to > > follow the standards, there might be some glitches between > > implementations). > > That's great. I will try once I finish my current task. So I tested it and fixed/modified many things. I changed the command names to vbeinfo and vbetest. More compatible with th= e=20 traditional GRUB's naming scheme. There were issues about the coding style. For example, a function definitio= n=20 must not be like this: int foo(int x) but: int foo (int x) Note the space character. This is the same for casts. Also, you needed to use GRUB's error handling. In GRUB 2, the error is not= =20 only a constant value, but also a message. So, whenever appropriate, you=20 should use the function grub_error. (This is a big improvement from GRUB=20 Legacy, really.) Please compare the files after my changes with yours for more details. =46or now, I tested it only with qemu, and haven't tested the vesafb termin= al=20 yet. Okuji