From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1E5vRD-0007Iv-O8 for mharc-grub-devel@gnu.org; Thu, 18 Aug 2005 21:12:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E5vQF-00073w-67 for grub-devel@gnu.org; Thu, 18 Aug 2005 21:11:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E5vQ9-00070K-7g for grub-devel@gnu.org; Thu, 18 Aug 2005 21:11:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E5vQ7-0006q2-6i for grub-devel@gnu.org; Thu, 18 Aug 2005 21:11:43 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E5vXz-0000RB-0V for grub-devel@gnu.org; Thu, 18 Aug 2005 21:19:51 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 3CC0011F22F14 for ; Fri, 19 Aug 2005 03:02:54 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 19 Aug 05 01:02:54 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 19 Aug 2005 03:01:35 +0200 User-Agent: KMail/1.7.2 References: <4304EE23.7010206@inma.ucl.ac.be> <87zmrf7yji.fsf@student.han.nl> <4304FB6C.1020600@inma.ucl.ac.be> In-Reply-To: <4304FB6C.1020600@inma.ucl.ac.be> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200508190301.35298.okuji@enbug.org> Subject: Re: backtrace support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2005 01:12:49 -0000 On Thursday 18 August 2005 23:19, Vincent Guffens wrote: > cool ! I will wait a little bit for your comments and those from Okuji > as there are a few changes I made that I'm not sure if they are very > clean, especially those in genmk.rb. Good job, Vincent. > I used some "cat config.h" and > maybe there are some better ways. Possibly you can substitute a variable in Makefile.in and use the variable. > Should the Changelog entries be included in the patch or is it generated > with the cvs log and it should then be sent in the mail body ? ChangeLog must be handwritten. As long as it is written well, I don't care about how you send it. Using the Change Log mode in Emacs would help you a lot. It is still necessary to clean up the patch. Running make twice does not sound good. One easy way is to build a separate backtrace module outside the kernel, and load it as soon as possible, like the normal module. Also, I think it would be better to rename --enable-backtrace to --enable-debug, so that we can enable all debugging features by one option (when we get more debugging features, this could be useful). Okuji